Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 174323003: Expose locks for CopyFromCompositingSurface/CopyFromBackingStore API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index 869e5377cfc124ff45606f5b7b7cee1b92bed7f8..13f6bf0917e5033b65fc8191069696f3cdd179c5 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -174,6 +174,8 @@ class RenderWidgetHostViewAndroid
const SkBitmap& zoomed_bitmap) OVERRIDE;
virtual scoped_ptr<SyntheticGestureTarget> CreateSyntheticGestureTarget()
OVERRIDE;
+ virtual void LockSurfaceForCopy() OVERRIDE;
+ virtual void UnlockSurfaceForCopy() OVERRIDE;
// Implementation of BrowserAccessibilityDelegate:
virtual void SetAccessibilityFocus(int acc_obj_id) OVERRIDE;
@@ -217,9 +219,6 @@ class RenderWidgetHostViewAndroid
void OnSetNeedsBeginFrame(bool enabled);
void OnSmartClipDataExtracted(const base::string16& result);
- void LockResources();
- void UnlockResources();
-
long GetNativeImeAdapter();
void WasResized();
@@ -292,6 +291,10 @@ class RenderWidgetHostViewAndroid
const base::Callback<void(bool, const SkBitmap&)>& callback,
const SkBitmap::Config config);
+ // Only use for when the content is forcibly being evicted, such as when
+ // ContentViewCore is gone or when the context has been lost.
piman 2014/03/04 19:09:55 nit: can you describe what it does rather than whe
powei 2014/03/04 20:49:22 Done.
+ void ReleaseLocksOnSurface();
+
// The model object.
RenderWidgetHostImpl* host_;

Powered by Google App Engine
This is Rietveld 408576698