Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1743183003: Remove unnecessary feature flag update. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
dstockwell
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary feature flag update. The feature flags in StyleEngine were always reset from StyleResolver::finishAppendAuthorStyleSheets right before we called combineCSSFeatureFlags with the exact same feature set. R=dstockwell@chromium.org BUG=401359, 567021 Committed: https://crrev.com/d91075970aa81e6d3a9ce9744248575947436507 Cr-Commit-Position: refs/heads/master@{#378719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743183003/1
4 years, 9 months ago (2016-02-29 15:12:49 UTC) #2
rune
ptal
4 years, 9 months ago (2016-02-29 15:13:26 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 16:12:56 UTC) #5
dstockwell
lgtm
4 years, 9 months ago (2016-03-01 23:22:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743183003/1
4 years, 9 months ago (2016-03-01 23:33:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/167217)
4 years, 9 months ago (2016-03-02 00:03:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743183003/1
4 years, 9 months ago (2016-03-02 00:41:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/189986)
4 years, 9 months ago (2016-03-02 02:36:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743183003/1
4 years, 9 months ago (2016-03-02 08:01:56 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 10:38:54 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 10:41:21 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d91075970aa81e6d3a9ce9744248575947436507
Cr-Commit-Position: refs/heads/master@{#378719}

Powered by Google App Engine
This is Rietveld 408576698