Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 174318: Introduce new async IPC message to get file icons (Closed)

Created:
11 years, 6 months ago by tkent
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Introduce new asynchronous IPC messages to request and response file icons. These messages will be used to show an icon on <input type=file> TEST=manual; Open http://new.crbug.com/, click 'Attach a file', select a file to a file upload control, and check if an icon is shown in the control. BUG=13225

Patch Set 1 : '' #

Total comments: 12

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -192 lines) Patch
M chrome/browser/renderer_host/render_view_host.h View 2 3 5 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 3 4 chunks +114 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 2 3 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 3 6 chunks +33 lines, -0 lines 0 comments Download
M third_party/WebKit/WebCore/WebCore.gypi View 2 3 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/Icon.h View 2 3 3 chunks +5 lines, -2 lines 0 comments Download
A + third_party/WebKit/WebCore/platform/graphics/chromium/IconChromium.cpp View 2 3 1 chunk +8 lines, -13 lines 0 comments Download
D third_party/WebKit/WebCore/platform/graphics/chromium/IconChromiumLinux.cpp View 2 3 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/WebCore/platform/graphics/chromium/IconChromiumMac.cpp View 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/WebCore/platform/graphics/chromium/IconChromiumWin.cpp View 1 2 3 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/chromium/PlatformIcon.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/WebKit/chromium/WebKit.gyp View 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/WebKit/chromium/public/WebIconLoadingCompletion.h View 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/WebKit/WebKit/chromium/public/WebViewClient.h View 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/WebKit/chromium/src/ChromeClientImpl.cpp View 2 3 2 chunks +7 lines, -2 lines 0 comments Download
A third_party/WebKit/WebKit/chromium/src/WebIconLoadingCompletionImpl.h View 2 3 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/WebKit/chromium/src/WebIconLoadingCompletionImpl.cpp View 2 3 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
tkent
Hi This is an incomplete patch. But I'd like to hear your comments early because ...
11 years, 6 months ago (2009-08-24 10:59:55 UTC) #1
jam
http://codereview.chromium.org/174318/diff/66/79 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/174318/diff/66/79#newcode192 Line 192: cancelable_consumer_.CancelAllRequests(); nit: no need for this, it already ...
11 years, 6 months ago (2009-08-24 17:39:10 UTC) #2
Peter Kasting
Darin, not I, is the right reviewer for this patch.
11 years, 6 months ago (2009-08-24 17:39:26 UTC) #3
jam
http://codereview.chromium.org/174318/diff/66/79 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/174318/diff/66/79#newcode725 Line 725: ui_loop()->PostTask(FROM_HERE, new GetIconForFilesTask( I forgot to mention: any ...
11 years, 6 months ago (2009-08-24 17:46:07 UTC) #4
Peter Kasting
This seems to have stalled. What's the status here?
11 years, 5 months ago (2009-10-01 18:46:52 UTC) #5
tkent
http://codereview.chromium.org/174318/diff/66/79 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/174318/diff/66/79#newcode192 Line 192: cancelable_consumer_.CancelAllRequests(); On 2009/08/24 17:39:11, John Abd-El-Malek wrote: > ...
11 years, 5 months ago (2009-10-02 07:12:30 UTC) #6
Peter Kasting
http://codereview.chromium.org/174318/diff/66/79 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/174318/diff/66/79#newcode725 Line 725: ui_loop()->PostTask(FROM_HERE, new GetIconForFilesTask( On 2009/10/02 07:12:30, Kent Tamura ...
11 years, 5 months ago (2009-10-02 17:38:08 UTC) #7
tkent
http://codereview.chromium.org/174318/diff/66/79 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/174318/diff/66/79#newcode725 Line 725: ui_loop()->PostTask(FROM_HERE, new GetIconForFilesTask( > Note that the IconManager ...
11 years, 5 months ago (2009-10-05 05:41:46 UTC) #8
jam
http://codereview.chromium.org/174318/diff/66/79 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/174318/diff/66/79#newcode725 Line 725: ui_loop()->PostTask(FROM_HERE, new GetIconForFilesTask( On 2009/10/02 17:38:08, Peter Kasting ...
11 years, 5 months ago (2009-10-05 06:48:34 UTC) #9
tkent
> You'll need to find a way to make the icon loader work on both ...
11 years, 3 months ago (2009-12-01 02:33:47 UTC) #10
darin (slow to review)
http://codereview.chromium.org/174318/diff/12013/11036 File third_party/WebKit/WebCore/platform/FileChooser.h (right): http://codereview.chromium.org/174318/diff/12013/11036#newcode48 third_party/WebKit/WebCore/platform/FileChooser.h:48: virtual Chrome* chrome() = 0; WebCore/platform should not depend ...
11 years, 3 months ago (2009-12-02 00:12:33 UTC) #11
tkent
http://codereview.chromium.org/174318/diff/12013/11036 File third_party/WebKit/WebCore/platform/FileChooser.h (right): http://codereview.chromium.org/174318/diff/12013/11036#newcode48 third_party/WebKit/WebCore/platform/FileChooser.h:48: virtual Chrome* chrome() = 0; On 2009/12/02 00:12:33, darin ...
11 years, 3 months ago (2009-12-02 05:31:59 UTC) #12
tkent
> Ok, I'll move chrome()->iconForFiles() call to RenderFileUpload.cpp, and send > the patch to http://bugs.webkit.org. ...
11 years, 3 months ago (2009-12-07 11:13:29 UTC) #13
tkent
Hi everyone, Asynchronous icon loading framework for WebKit was landed. Would you review this change ...
10 years, 10 months ago (2010-05-12 11:01:21 UTC) #14
jam
hi, does this really need 3 reviewers?
10 years, 10 months ago (2010-05-13 18:17:25 UTC) #15
Peter Kasting
This seems to have died. Kent, is it still valid and in need of review?
10 years, 7 months ago (2010-07-27 19:29:45 UTC) #16
tkent
On 2010/07/27 19:29:45, Peter Kasting wrote: > This seems to have died. Kent, is it ...
10 years, 7 months ago (2010-07-28 03:21:55 UTC) #17
Peter Kasting
On 2010/07/28 03:21:55, Kent Tamura wrote: > On 2010/07/27 19:29:45, Peter Kasting wrote: > > ...
9 years, 10 months ago (2011-04-21 20:07:16 UTC) #18
tkent
On 2011/04/21 20:07:16, Peter Kasting wrote: > Did the WK change ever land here? This ...
9 years, 10 months ago (2011-04-21 21:45:38 UTC) #19
Peter Kasting
Another ping here. If this just needs a rebase and upload, could you go ahead ...
8 years, 8 months ago (2012-06-13 19:15:22 UTC) #20
tkent
8 years, 8 months ago (2012-06-14 04:49:34 UTC) #21
Thank you for the ping.
I rebased the patch after your last ping, and the patched chrome didn't work
unfortunately.  I need to make time to investigate it.

Powered by Google App Engine
This is Rietveld 408576698