Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/WebKit/chromium/src/ChromeClientImpl.cpp

Issue 174318: Introduce new async IPC message to get file icons (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/WebKit/chromium/src/ChromeClientImpl.cpp
===================================================================
--- third_party/WebKit/WebKit/chromium/src/ChromeClientImpl.cpp (revision 58975)
+++ third_party/WebKit/WebKit/chromium/src/ChromeClientImpl.cpp (working copy)
@@ -64,6 +64,7 @@
#include "WebFileChooserCompletionImpl.h"
#include "WebFrameClient.h"
#include "WebFrameImpl.h"
+#include "WebIconLoadingCompletionImpl.h"
#include "WebInputEvent.h"
#include "WebKit.h"
#include "WebPopupMenuImpl.h"
@@ -603,9 +604,13 @@
chooserCompletion->didChooseFile(WebVector<WebString>());
}
-void ChromeClientImpl::chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*)
+void ChromeClientImpl::chooseIconForFiles(const Vector<WebCore::String>& filenames, WebCore::FileChooser* fileChooser)
{
- notImplemented();
+ if (!m_webView->client())
+ return;
+ WebIconLoadingCompletionImpl* iconCompletion = new WebIconLoadingCompletionImpl(fileChooser);
+ if (!m_webView->client()->chooseIconForFiles(filenames, iconCompletion))
+ iconCompletion->iconLoaded(WebData());
}
void ChromeClientImpl::popupOpened(PopupContainer* popupContainer,

Powered by Google App Engine
This is Rietveld 408576698