Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1743163002: Service Worker: Enable Clients.get(id) (Closed)

Created:
4 years, 9 months ago by jungkees
Modified:
4 years, 9 months ago
Reviewers:
tkent, falken, zino, nhiroki
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
jungkees
As discussed in https://bugs.chromium.org/p/chromium/issues/detail?id=552310#c12, I uploaded a patch to enable Clients.get(id). PTAL
4 years, 9 months ago (2016-02-29 08:27:53 UTC) #3
nhiroki
lgtm
4 years, 9 months ago (2016-02-29 08:50:34 UTC) #4
jungkees
tkent@, could you review it?
4 years, 9 months ago (2016-02-29 10:25:50 UTC) #5
tkent
lgtm
4 years, 9 months ago (2016-02-29 23:11:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743163002/1
4 years, 9 months ago (2016-03-02 01:32:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/174976)
4 years, 9 months ago (2016-03-02 01:59:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743163002/1
4 years, 9 months ago (2016-03-02 02:45:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 03:48:12 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 03:50:33 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d2d3a059242663ac56cb036c2fb0bba0d7322d6
Cr-Commit-Position: refs/heads/master@{#378678}

Powered by Google App Engine
This is Rietveld 408576698