content/browser/frame_host/render_frame_host_impl_browsertest.cc - Issue 1743143002: Remove WebContents::Was{Hidden,Shown}() from the content public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl_browsertest.cc

Issue 1743143002: Remove WebContents::Was{Hidden,Shown}() from the content public interface Base URL: https://chromium.googlesource.com/chromium/src.git@20160225-WebContents-DicardCursorRects

Patch Set: Fix androido Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/base/chrome_render_view_host_test_harness.cc ('k') | content/browser/web_contents/web_contents_android.cc » ('j') | content/public/browser/web_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl_browsertest.cc

diff --git a/content/browser/frame_host/render_frame_host_impl_browsertest.cc b/content/browser/frame_host/render_frame_host_impl_browsertest.cc

index 6547788162e29da908890e6a50eea3035d1c3ede..9198f8abd83dd3af59c00b42b7ccb40d62b9b2f9 100644

--- a/content/browser/frame_host/render_frame_host_impl_browsertest.cc

+++ b/content/browser/frame_host/render_frame_host_impl_browsertest.cc

@@ -125,7 +125,8 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest, RemoveFocusedFrame) {

IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest,

GetVisibilityState_Basic) {

EXPECT_TRUE(NavigateToURL(shell(), GURL("data:text/html,foo")));

- WebContents* web_contents = shell()->web_contents();

+ WebContentsImpl* web_contents =

+ static_cast<WebContentsImpl*>(shell()->web_contents());

web_contents->WasShown();

EXPECT_EQ(blink::WebPageVisibilityStateVisible,

@@ -140,7 +141,8 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest,

IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest,

GetVisibilityState_Override) {

EXPECT_TRUE(NavigateToURL(shell(), GURL("data:text/html,foo")));

- WebContents* web_contents = shell()->web_contents();

+ WebContentsImpl* web_contents =

+ static_cast<WebContentsImpl*>(shell()->web_contents());

PrerenderTestContentBrowserClient new_client;

ContentBrowserClient* old_client = SetBrowserClientForTesting(&new_client);