chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 1743143002: Remove WebContents::Was{Hidden,Shown}() from the content public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 1743143002: Remove WebContents::Was{Hidden,Shown}() from the content public interface Base URL: https://chromium.googlesource.com/chromium/src.git@20160225-WebContents-DicardCursorRects

Patch Set: Fix androido Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | content/public/browser/web_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index 44ff512cb03918a089e745316e448f7ee34aa252..4c87b35f15d23486a20f0d73e27a20dc0d5c702d 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -7,6 +7,7 @@

#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

#include "components/page_load_metrics/common/page_load_metrics_messages.h"

+#include "content/public/test/web_contents_tester.h"

namespace page_load_metrics {

@@ -50,7 +51,7 @@ void PageLoadMetricsObserverTestHarness::SetUp() {

MetricsWebContentsObserver::CreateForWebContents(

web_contents(),

make_scoped_ptr(new TestPageLoadMetricsEmbedderInterface(this)));

- web_contents()->WasShown();

+ SimulateShow();

}

void PageLoadMetricsObserverTestHarness::StartNavigation(const GURL& gurl) {