chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc - Issue 1743143002: Remove WebContents::Was{Hidden,Shown}() from the content public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

Issue 1743143002: Remove WebContents::Was{Hidden,Shown}() from the content public interface Base URL: https://chromium.googlesource.com/chromium/src.git@20160225-WebContents-DicardCursorRects

Patch Set: Fix androido Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h » ('j') | content/public/browser/web_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

index ac68b5f5e71dd5ad43f8f1f2c2e0de50add1138e..067fa7ceba026fad9db4a297a362a846b539680a 100644

--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

@@ -110,7 +110,7 @@ TEST_F(FromGWSPageLoadMetricsObserverTest, ReferralFromGWSBackgroundLater) {

NavigateAndCommit(GURL("https://www.example.com"));

SimulateTimingUpdate(timing);

- web_contents()->WasHidden();

+ SimulateHide();

// Navigate again to force logging.

NavigateAndCommit(GURL("https://www.example2.com"));