Subzero: Fix JumpTable lowering on x86-64.

Subzero: Fix JumpTable lowering on x86-64.

The problem is that when switch lowering decides to use a JumpTable and the switch variable is i64 on x86-64, the lowering tries to movzx the i64 variable into an i32 variable, and the Movzx ctor asserts.

This happens when translating pnacl-llc.pexe, but luckily it is also triggered in the existing adv-switch.ll test.

BUG= none
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e641e92cb728bb01453d926fa4e69ba8b9ae53bb

[Jim Stichnoth, 2016-02-29 04:53:48]

Description was changed from

==========
Subzero: Fix JumpTable lowering on x86-64.

BUG= none
==========

to

==========
Subzero: Fix JumpTable lowering on x86-64.

The problem is that when switch lowering decides to use a JumpTable and the
switch variable is i64 on x86-64, the lowering tries to movzx the i64 variable
into an i32 variable, and the Movzx ctor asserts.

This happens when translating pnacl-llc.pexe, but luckily it is also triggered
in the existing adv-switch.ll test.

BUG= none
==========

[Jim Stichnoth, 2016-02-29 04:54:49]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[John, 2016-02-29 15:34:09]

lgtm

https://codereview.chromium.org/1743133002/diff/20001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1743133002/diff/20001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86BaseImpl.h:5856: if (RangeIndex->getType() ==
IceType_i64) {
How do you feel about:

if (typeSizeInByes(PointerType) > typSizeInBytes(RangeIndex.getType()) {
  Index = makeReg(PointerType);
  _movzx(Index, RangeIndex);
} else if (typeSizeInByes(PointerType) < typSizeInBytes(RangeIndex.getType()) {
  Index = makeReg(PointerType);
  _mov(Index, RangeIndex);
} else {
  Index = legalizeToReg(RangeIndex);
}

This is "moar" future-proof should we ever need a non-ILP32 target.

https://codereview.chromium.org/1743133002/diff/20001/tests_lit/llvm2ice_test...
File tests_lit/llvm2ice_tests/adv-switch-opt.ll (right):

https://codereview.chromium.org/1743133002/diff/20001/tests_lit/llvm2ice_test...
tests_lit/llvm2ice_tests/adv-switch-opt.ll:4: ; RUN: %p2i -i %s --target=x8632
--filetype=obj --disassemble --args -O2 \
enable the other lit tests, too?

[Jim Stichnoth, 2016-02-29 17:53:18]

https://codereview.chromium.org/1743133002/diff/20001/tests_lit/llvm2ice_test...
File tests_lit/llvm2ice_tests/adv-switch-opt.ll (right):

https://codereview.chromium.org/1743133002/diff/20001/tests_lit/llvm2ice_test...
tests_lit/llvm2ice_tests/adv-switch-opt.ll:4: ; RUN: %p2i -i %s --target=x8632
--filetype=obj --disassemble --args -O2 \
On 2016/02/29 15:34:09, John wrote:
> enable the other lit tests, too?

Clarified offline.  Most of the tests are run for both targets, due to the
multiple "--check-prefix" arguments.

[Jim Stichnoth, 2016-02-29 17:54:59]

Description was changed from

==========
Subzero: Fix JumpTable lowering on x86-64.

The problem is that when switch lowering decides to use a JumpTable and the
switch variable is i64 on x86-64, the lowering tries to movzx the i64 variable
into an i32 variable, and the Movzx ctor asserts.

This happens when translating pnacl-llc.pexe, but luckily it is also triggered
in the existing adv-switch.ll test.

BUG= none
==========

to

==========
Subzero: Fix JumpTable lowering on x86-64.

The problem is that when switch lowering decides to use a JumpTable and the
switch variable is i64 on x86-64, the lowering tries to movzx the i64 variable
into an i32 variable, and the Movzx ctor asserts.

This happens when translating pnacl-llc.pexe, but luckily it is also triggered
in the existing adv-switch.ll test.

BUG= none
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-02-29 17:55:01]

Committed patchset #2 (id:20001) manually as
e641e92cb728bb01453d926fa4e69ba8b9ae53bb (tree was closed).