Chromium Code Reviews| Index: rietveld.py |
| diff --git a/rietveld.py b/rietveld.py |
| index 5528c551a6af1278fb83b9c3413547da2cfa6709..0720293c6f7417c984c6b63ea1f51977c4f056df 100644 |
| --- a/rietveld.py |
| +++ b/rietveld.py |
| @@ -367,6 +367,9 @@ class Rietveld(object): |
| def _send(self, request_path, **kwargs): |
| """Sends a POST/GET to Rietveld. Returns the response body.""" |
| + # Code below assumes timeout=None by default; make sure it's set |
|
Paweł Hajdan Jr.
2014/02/21 00:49:30
nit: Let's be more precise and say rpc_server (or
Sergey Berezin
2014/02/21 01:30:56
Done.
|
| + # to something reasonable. |
| + kwargs.setdefault('timeout', 15) |
| logging.debug('POSTing to %s, args %s.', request_path, kwargs) |
| try: |
| # Sadly, upload.py calls ErrorExit() which does a sys.exit(1) on HTTP |