Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1743123002: X87: [runtime] Unify comparison operator runtime entries. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Unify comparison operator runtime entries. port 55b4df7357557eb16377ad9227e4e0a4224b7885(r34303) original commit message: Only use one set of %StrictEquals/%StrictNotEquals and %Equals/%NotEquals runtime entries for both the interpreter and the old-style CompareICStub. The long-term plan is to update the CompareICStub to also return boolean values, and even allow some more code sharing with the interpreter there. BUG= Committed: https://crrev.com/2aa534105079559235950bafd51d82036f320335 Cr-Commit-Position: refs/heads/master@{#34352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-02-29 02:54:13 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-02-29 03:04:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743123002/1
4 years, 9 months ago (2016-02-29 03:09:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 03:29:25 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 03:30:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2aa534105079559235950bafd51d82036f320335
Cr-Commit-Position: refs/heads/master@{#34352}

Powered by Google App Engine
This is Rietveld 408576698