Add test_skia.py, isolates for test_skia, images, skps

Add test_skia.py, isolates for test_skia, images, skps

This enables running DM through Swarming.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1743113003

Committed: https://skia.googlesource.com/skia/+/a7a6f2e01d07a0e01fca948dfca5c5f4df24b5f9

[borenet, 2016-02-29 12:31:56]

Description was changed from

==========
Add test_skia.py, isolates for test_skia, images, skps

This enables running DM through Swarming.

BUG=skia:4763
==========

to

==========
Add test_skia.py, isolates for test_skia, images, skps

This enables running DM through Swarming.

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-02-29 12:42:16]

borenet@google.com changed reviewers:
+ rmistry@google.com

[borenet, 2016-02-29 12:42:17]

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/download_ima...
File infra/bots/download_images.py (right):

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/download_ima...
infra/bots/download_images.py:1: #!/usr/bin/env python
This and download_skps are not used yet, but they're a simple way to provide the
inputs for images.isolate and skps.isolate, which will be helpful down the road.

[rmistry, 2016-02-29 13:01:34]

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/common.py
File infra/bots/common.py (right):

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/common.py#ne...
infra/bots/common.py:117: HASHES_URL = 'https://gold.skia.org/_/hashes'
Make module level constant?

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/common.py#ne...
infra/bots/common.py:123: for retry in range(RETRIES):
Would be useful to add a utility for exponential retries. You can then use it as
a one-line decorator on any function that would benefit from it.

For example I added one to Monorail:
https://chromereviews.googleplex.com/234687013/

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/test_skia.py
File infra/bots/test_skia.py (right):

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/test_skia.py...
infra/bots/test_skia.py:15: if len(sys.argv) != 7:
It will make things much more readable and maintainable if you use optparse
here. You can then use in the isolate '--master',  '<(MASTER_NAME)' etc.
Should also do this in compile_skia.py

[borenet, 2016-02-29 13:53:54]

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/common.py
File infra/bots/common.py (right):

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/common.py#ne...
infra/bots/common.py:117: HASHES_URL = 'https://gold.skia.org/_/hashes'
On 2016/02/29 13:01:34, rmistry wrote:
> Make module level constant?

Done.

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/common.py#ne...
infra/bots/common.py:123: for retry in range(RETRIES):
On 2016/02/29 13:01:34, rmistry wrote:
> Would be useful to add a utility for exponential retries. You can then use it
as
> a one-line decorator on any function that would benefit from it.
> 
> For example I added one to Monorail:
> https://chromereviews.googleplex.com/234687013/

If it's okay with you I'd prefer to save that until we have another use case for
it.

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/test_skia.py
File infra/bots/test_skia.py (right):

https://codereview.chromium.org/1743113003/diff/20001/infra/bots/test_skia.py...
infra/bots/test_skia.py:15: if len(sys.argv) != 7:
On 2016/02/29 13:01:34, rmistry wrote:
> It will make things much more readable and maintainable if you use optparse
> here. You can then use in the isolate '--master',  '<(MASTER_NAME)' etc.
> Should also do this in compile_skia.py

Done.

[rmistry, 2016-02-29 13:55:22]

lgtm

[borenet, 2016-02-29 13:56:31]

Description was changed from

==========
Add test_skia.py, isolates for test_skia, images, skps

This enables running DM through Swarming.

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add test_skia.py, isolates for test_skia, images, skps

This enables running DM through Swarming.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-02-29 13:56:37]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-02-29 13:56:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743113003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743113003/40001

[commit-bot: I haz the power, 2016-02-29 13:57:34]

Description was changed from

==========
Add test_skia.py, isolates for test_skia, images, skps

This enables running DM through Swarming.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add test_skia.py, isolates for test_skia, images, skps

This enables running DM through Swarming.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a7a6f2e01d07a0e01fca948dfca5c5f4df24b5f9
==========

[commit-bot: I haz the power, 2016-02-29 13:57:35]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a7a6f2e01d07a0e01fca948dfca5c5f4df24b5f9