chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 17431003: Dragging panels near screen edge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 17431003: Dragging panels near screen edge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Dragging panels near screen edge (comments) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 81d938e97ae29e6b6e555527f49811fd90f2a4f9..77f08ca2aa585bb43dc82b5e853ed442c0e7d5b4 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -752,6 +752,8 @@ bool WindowsUpdateFunction::RunImpl() {

bounds = controller->window()->GetRestoredBounds();

else

bounds = controller->window()->GetBounds();

+ // TODO: Updating bounds during a drag can cause problems and a more general

+ // solution is needed. See http://crbug.com/251813 .

flackr 2013/06/20 23:00:57 nit: I'd put this on the call to SetBounds.

varkha 2013/06/20 23:10:04 Done.

bool set_bounds = false;

// Any part of the bounds can optionally be set by the caller.