Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1743043002: Subzero: Print memory usage info when dumping. (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Print memory usage info when dumping. Adds "-verbose mem" to enable printing the amount of CfgLocalAllocator memory allocated, each time Cfg::dump() is called. "-verbose mem,status" is a good way to get summary info. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3dd1bb87cda35313a26daa37cebf3962181da053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/IceCfg.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M src/IceClFlags.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceDefs.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 9 months ago (2016-02-27 16:16:38 UTC) #3
Karl
lgtm
4 years, 9 months ago (2016-02-27 16:44:55 UTC) #4
Jim Stichnoth
4 years, 9 months ago (2016-02-27 17:05:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3dd1bb87cda35313a26daa37cebf3962181da053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698