[css-flexbox] Correctly resolve percentages in children of stretched flex items

third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1008 matching lines @@
             transferredSize = adjustChildSizeForAspectRatioCrossAxisMinAndMax(child, transferredSize);
             minExtent = std::min(transferredSize, contentSize);
         } else {
             minExtent = contentSize;
         }
     }
     ASSERT(minExtent >= 0);
     return std::max(childSize, minExtent);
 }
 
+LayoutUnit LayoutFlexibleBox::crossSizeForPercentageResolution(const LayoutBox& child)
+{
+    if (isMultiline() || alignmentForChild(child) != ItemPositionStretch || hasAutoMarginsInCrossAxis(child))

[leviw_travelin_and_unemployed, 2016/03/01 23:53:56]

Is there a part of the spec that specifically mentions the multiline case? If
so, can we reference it here?

[cbiesinger, 2016/03/02 03:19:37]

Done.

+        return LayoutUnit(-1);
+
+    const Length& childCrossLength = isHorizontalFlow() ? child.styleRef().height() : child.styleRef().width();
+    if (crossAxisLengthIsDefinite(child, childCrossLength))
+        return LayoutUnit(-1);
+
+    LayoutUnit childCrossSize;
+
+    LogicalExtentComputedValues computedValues;
+    if (isColumnFlow()) {
+        const Length& widthLength = styleRef().logicalWidth();
+        if (widthLength.isAuto() || (widthLength.hasPercent() && !hasDefiniteLogicalWidth()))
+            return LayoutUnit(-1);
+
+        computeLogicalWidth(computedValues);
+        if (computedValues.m_extent == LayoutUnit(-1))
+            return LayoutUnit(-1);
+        childCrossSize = computedValues.m_extent - borderAndPaddingLogicalWidth() - scrollbarLogicalWidth();
+        childCrossSize = child.constrainLogicalWidthByMinMax(childCrossSize, childCrossSize, this) - child.scrollbarLogicalWidth() - child.borderAndPaddingLogicalWidth();
+    } else {
+        const Length& heightLength = styleRef().logicalHeight();
+        if (heightLength.isAuto() || (heightLength.hasPercent() && computePercentageLogicalHeight(heightLength) == -1))
+            return LayoutUnit(-1);
+
+        computeLogicalHeight(LayoutUnit(-1), LayoutUnit(), computedValues);
+        childCrossSize = computedValues.m_extent - borderAndPaddingLogicalHeight() - scrollbarLogicalHeight();
+        childCrossSize = child.constrainLogicalHeightByMinMax(childCrossSize, LayoutUnit(-1)) - child.scrollbarLogicalHeight() - child.borderAndPaddingLogicalHeight();
+    }
+    return childCrossSize;
+}
+
+LayoutUnit LayoutFlexibleBox::childLogicalHeightForPercentageResolution(const LayoutBox& child)
+{
+    if (!hasOrthogonalFlow(child))
+        return crossSizeForPercentageResolution(child);
+    return LayoutUnit(-1);
+}
+
+LayoutUnit LayoutFlexibleBox::childLogicalWidthForPercentageResolution(const LayoutBox& child)
+{
+    if (hasOrthogonalFlow(child))
+        return crossSizeForPercentageResolution(child);
+    return LayoutUnit(-1);
+}
+
 LayoutUnit LayoutFlexibleBox::adjustChildSizeForAspectRatioCrossAxisMinAndMax(const LayoutBox& child, LayoutUnit childSize)
 {
     Length crossMin = isHorizontalFlow() ? child.style()->minHeight() : child.style()->minWidth();
     Length crossMax = isHorizontalFlow() ? child.style()->maxHeight() : child.style()->maxWidth();
 
 
     if (crossAxisLengthIsDefinite(child, crossMax)) {
         LayoutUnit maxValue = computeMainSizeFromAspectRatioUsing(child, crossMax);
         childSize = std::min(maxValue, childSize);
     }
@@ skipping 623 matching lines @@
             ASSERT(child);
             LayoutUnit lineCrossAxisExtent = lineContexts[lineNumber].crossAxisExtent;
             LayoutUnit originalOffset = lineContexts[lineNumber].crossAxisOffset - crossAxisStartEdge;
             LayoutUnit newOffset = contentExtent - originalOffset - lineCrossAxisExtent;
             adjustAlignmentForChild(*child, newOffset - originalOffset);
         }
     }
 }
 
 } // namespace blink