Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

Issue 1742973002: [css-flexbox] Correctly resolve percentages in children of stretched flex items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests fixed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePo sitionMode = PositionOnContainingLine) const override; 53 int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePo sitionMode = PositionOnContainingLine) const override;
54 int firstLineBoxBaseline() const override; 54 int firstLineBoxBaseline() const override;
55 int inlineBlockBaseline(LineDirectionMode) const override; 55 int inlineBlockBaseline(LineDirectionMode) const override;
56 56
57 void paintChildren(const PaintInfo&, const LayoutPoint&) const final; 57 void paintChildren(const PaintInfo&, const LayoutPoint&) const final;
58 58
59 bool isHorizontalFlow() const; 59 bool isHorizontalFlow() const;
60 60
61 const OrderIterator& orderIterator() const { return m_orderIterator; } 61 const OrderIterator& orderIterator() const { return m_orderIterator; }
62 62
63 LayoutUnit crossSizeForPercentageResolution(const LayoutBox& child);
64 LayoutUnit childLogicalHeightForPercentageResolution(const LayoutBox& child) ;
65 LayoutUnit childLogicalWidthForPercentageResolution(const LayoutBox& child);
leviw_travelin_and_unemployed 2016/03/01 01:58:51 This is never called.
cbiesinger 2016/03/01 20:36:10 This is now used.
66
63 void clearCachedMainSizeForChild(const LayoutBox& child); 67 void clearCachedMainSizeForChild(const LayoutBox& child);
64 protected: 68 protected:
65 void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const override; 69 void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const override;
66 70
67 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ; 71 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ;
68 void removeChild(LayoutObject*) override; 72 void removeChild(LayoutObject*) override;
69 73
70 private: 74 private:
71 enum FlexSign { 75 enum FlexSign {
72 PositiveFlexibility, 76 PositiveFlexibility,
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 189
186 mutable OrderIterator m_orderIterator; 190 mutable OrderIterator m_orderIterator;
187 int m_numberOfInFlowChildrenOnFirstLine; 191 int m_numberOfInFlowChildrenOnFirstLine;
188 }; 192 };
189 193
190 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFlexibleBox, isFlexibleBox()); 194 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFlexibleBox, isFlexibleBox());
191 195
192 } // namespace blink 196 } // namespace blink
193 197
194 #endif // LayoutFlexibleBox_h 198 #endif // LayoutFlexibleBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698