Simplify ash shelf layout code.

Simplify ash shelf layout code.

Remove Shelf::[G|S]etShelfViewBounds.
Remove ShelfWidget::DelegateView::Layout override.
Use FillLayout instead, with an empty border on the parent.

Use ScreenUtil::GetShelfDisplayBoundsInRoot consistently.
Refactor ShelfLayoutManager::CalculateTargetBounds, etc.

BUG=57406
TEST=No behavior changes or regressions.
R=sky@chromium.org

Committed: https://crrev.com/932c2ee1d4a454f926a725c38a3b5f78c88a0667
Cr-Commit-Position: refs/heads/master@{#378707}

[msw, 2016-02-27 02:04:29]

Description was changed from

==========
Simplify ash shelf layout code.

BUG=57406
==========

to

==========
Simplify ash shelf layout code.

TODO: Fix:
--gtest_filter=ShelfLayoutManagerTest.AutoHideShelfOnScreenBoundary:ShelfLayoutManagerTest.DualDisplayOpenAppListWithShelfAutoHideState:ShelfLayoutManagerTest.GestureDrag:ShelfLayoutManagerTest.GestureEdgeSwipeMultiMonitor:ShelfLayoutManagerTest.ShelfAnimatesWhenGestureComplete:ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop:ShelfLayoutManagerTest.ShelfUpdatedWhenStatusAreaChangesSize:ShelfLayoutManagerTest.ShelfWithSystemModalWindowDualDisplay:ShelfViewTest.CheckDragInsertBoundsWithMultiMonitor:ShelfViewTest.CheckRipOffFromLeftShelfAlignmentWithMultiMonitor

BUG=57406
==========

[msw, 2016-03-01 01:32:02]

Description was changed from

==========
Simplify ash shelf layout code.

TODO: Fix:
--gtest_filter=ShelfLayoutManagerTest.AutoHideShelfOnScreenBoundary:ShelfLayoutManagerTest.DualDisplayOpenAppListWithShelfAutoHideState:ShelfLayoutManagerTest.GestureDrag:ShelfLayoutManagerTest.GestureEdgeSwipeMultiMonitor:ShelfLayoutManagerTest.ShelfAnimatesWhenGestureComplete:ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop:ShelfLayoutManagerTest.ShelfUpdatedWhenStatusAreaChangesSize:ShelfLayoutManagerTest.ShelfWithSystemModalWindowDualDisplay:ShelfViewTest.CheckDragInsertBoundsWithMultiMonitor:ShelfViewTest.CheckRipOffFromLeftShelfAlignmentWithMultiMonitor

BUG=57406
==========

to

==========
Simplify ash shelf layout code.

TODO: Fix:
--gtest_filter=ShelfLayoutManagerTest.AutoHideShelfOnScreenBoundary:ShelfLayoutManagerTest.DualDisplayOpenAppListWithShelfAutoHideState:ShelfLayoutManagerTest.GestureDrag:ShelfLayoutManagerTest.GestureEdgeSwipeMultiMonitor:ShelfLayoutManagerTest.ShelfAnimatesWhenGestureComplete:ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop:ShelfLayoutManagerTest.ShelfWithSystemModalWindowDualDisplay:ShelfViewTest.CheckDragInsertBoundsWithMultiMonitor:ShelfViewTest.CheckRipOffFromLeftShelfAlignmentWithMultiMonitor

BUG=57406
==========

[msw, 2016-03-01 21:18:36]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2016-03-01 21:19:19]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-03-01 21:19:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1742953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1742953002/40001

[commit-bot: I haz the power, 2016-03-01 21:23:05]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-03-01 21:41:05]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 21:41:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1742953002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1742953002/60001

[commit-bot: I haz the power, 2016-03-01 22:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 22:02:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-03-01 22:05:08]

Description was changed from

==========
Simplify ash shelf layout code.

TODO: Fix:
--gtest_filter=ShelfLayoutManagerTest.AutoHideShelfOnScreenBoundary:ShelfLayoutManagerTest.DualDisplayOpenAppListWithShelfAutoHideState:ShelfLayoutManagerTest.GestureDrag:ShelfLayoutManagerTest.GestureEdgeSwipeMultiMonitor:ShelfLayoutManagerTest.ShelfAnimatesWhenGestureComplete:ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop:ShelfLayoutManagerTest.ShelfWithSystemModalWindowDualDisplay:ShelfViewTest.CheckDragInsertBoundsWithMultiMonitor:ShelfViewTest.CheckRipOffFromLeftShelfAlignmentWithMultiMonitor

BUG=57406
==========

to

==========
Simplify ash shelf layout code.

TODO: Fix:
--gtest_filter=ShelfViewTest.CheckDragInsertBoundsWithMultiMonitor:ShelfViewTest.CheckRipOffFromLeftShelfAlignmentWithMultiMonitor

BUG=57406
==========

[msw, 2016-03-01 22:36:07]

Description was changed from

==========
Simplify ash shelf layout code.

TODO: Fix:
--gtest_filter=ShelfViewTest.CheckDragInsertBoundsWithMultiMonitor:ShelfViewTest.CheckRipOffFromLeftShelfAlignmentWithMultiMonitor

BUG=57406
==========

to

==========
Simplify ash shelf layout code.

TODO: Fix broken tests...

BUG=57406
==========

[msw, 2016-03-01 23:09:30]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 23:10:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1742953002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1742953002/80001

[msw, 2016-03-01 23:50:17]

Description was changed from

==========
Simplify ash shelf layout code.

TODO: Fix broken tests...

BUG=57406
==========

to

==========
Simplify ash shelf layout code.

Remove Shelf::[G|S]etShelfViewBounds.
Remove ShelfWidget::DelegateView::Layout override.
Use FillLayout instead, with an empty border on the parent.

Use ScreenUtil::GetShelfDisplayBoundsInRoot consistently.
Refactor ShelfLayoutManager::CalculateTargetBounds, etc. 

BUG=57406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

[msw, 2016-03-01 23:50:17]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-03-02 00:03:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 00:03:52]

Dry run: This issue passed the CQ dry run.

[msw, 2016-03-02 00:04:59]

Hey Scott, please take a look; thanks!
(this isn't necessary, but seems cleaner)

[sky, 2016-03-02 03:38:31]

LGTM

[msw, 2016-03-02 06:53:42]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-03-02 06:53:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1742953002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1742953002/80001

[commit-bot: I haz the power, 2016-03-02 06:59:09]

Description was changed from

==========
Simplify ash shelf layout code.

Remove Shelf::[G|S]etShelfViewBounds.
Remove ShelfWidget::DelegateView::Layout override.
Use FillLayout instead, with an empty border on the parent.

Use ScreenUtil::GetShelfDisplayBoundsInRoot consistently.
Refactor ShelfLayoutManager::CalculateTargetBounds, etc. 

BUG=57406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Simplify ash shelf layout code.

Remove Shelf::[G|S]etShelfViewBounds.
Remove ShelfWidget::DelegateView::Layout override.
Use FillLayout instead, with an empty border on the parent.

Use ScreenUtil::GetShelfDisplayBoundsInRoot consistently.
Refactor ShelfLayoutManager::CalculateTargetBounds, etc. 

BUG=57406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-03-02 06:59:11]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-03-02 07:00:54]

Description was changed from

==========
Simplify ash shelf layout code.

Remove Shelf::[G|S]etShelfViewBounds.
Remove ShelfWidget::DelegateView::Layout override.
Use FillLayout instead, with an empty border on the parent.

Use ScreenUtil::GetShelfDisplayBoundsInRoot consistently.
Refactor ShelfLayoutManager::CalculateTargetBounds, etc. 

BUG=57406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Simplify ash shelf layout code.

Remove Shelf::[G|S]etShelfViewBounds.
Remove ShelfWidget::DelegateView::Layout override.
Use FillLayout instead, with an empty border on the parent.

Use ScreenUtil::GetShelfDisplayBoundsInRoot consistently.
Refactor ShelfLayoutManager::CalculateTargetBounds, etc.

BUG=57406
TEST=No behavior changes or regressions.
R=sky@chromium.org

Committed: https://crrev.com/932c2ee1d4a454f926a725c38a3b5f78c88a0667
Cr-Commit-Position: refs/heads/master@{#378707}
==========

[commit-bot: I haz the power, 2016-03-02 07:00:55]

Patchset 4 (id:??) landed as
https://crrev.com/932c2ee1d4a454f926a725c38a3b5f78c88a0667
Cr-Commit-Position: refs/heads/master@{#378707}