Source/core/dom/Element.cpp - Issue 174293005: Fix crash in which elementData() might be null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 174293005: Fix crash in which elementData() might be null. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index aaf9cf83c96d74f097ffa568dc2c566ebdbed5e5..66c205a0c71b86cbdf4b08d409fdba30c571e969 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -1087,6 +1087,7 @@ void Element::classAttributeChanged(const AtomicString& newClassString)

StyleResolver* styleResolver = document().styleResolver();

bool testShouldInvalidateStyle = inActiveDocument() && styleResolver && styleChangeType() < SubtreeStyleChange;

+ ASSERT(elementData());

if (classStringHasClassName(newClassString)) {

const bool shouldFoldCase = document().inQuirksMode();

const SpaceSplitString oldClasses = elementData()->classNames();