LayoutTests/svg/dom/set-class-attribute.html - Issue 174293005: Fix crash in which elementData() might be null.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/dom/set-class-attribute.html

Issue 174293005: Fix crash in which elementData() might be null. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed comment. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <body>

	4 Test for crbug.com/345178: This test passes if it does not crash<br/>
	adamk 2014/02/24 22:33:19 Actually, you'll also want to add an expected.txt Actually, you'll also want to add an expected.txt for this test, and set testRunner.dumpAsText() to avoid creating pixel results. chrishtr 2014/02/24 22:41:21 Done. Show quoted text On 2014/02/24 22:33:19, adamk wrote: > Actually, you'll also want to add an expected.txt for this test, and set > testRunner.dumpAsText() to avoid creating pixel results. Done.
	5 <svg>

	6 <set attributename="class" />

	7 </svg>

	8 </body>

	9 </html>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/dom/Element.cpp » ('j') | no next file with comments »