net/cert/internal/verify_signed_data_unittest.cc - Issue 1742873002: Switch //net to the new SPKI and PKCS#8 APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/verify_signed_data_unittest.cc

Issue 1742873002: Switch //net to the new SPKI and PKCS#8 APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@spki-crypto

Patch Set: tweak keygen_handler_openssl.cc Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/internal/verify_signed_data_unittest.cc

diff --git a/net/cert/internal/verify_signed_data_unittest.cc b/net/cert/internal/verify_signed_data_unittest.cc

index 239aaaecbc778a56a4a18ba62fb014428e300200..43a4856b3124d0b3ba15690294828c8c608e5ec0 100644

--- a/net/cert/internal/verify_signed_data_unittest.cc

+++ b/net/cert/internal/verify_signed_data_unittest.cc

@@ -101,9 +101,7 @@ TEST(VerifySignedDataTest, Rsa2048Pkcs1Sha512) {

}

TEST(VerifySignedDataTest, RsaPkcs1Sha256KeyEncodedBer) {

- // TODO(eroman): This should fail! (SPKI should be DER-encoded). See

- // https://crbug.com/522228

- RunTestCase(SUCCESS, "rsa-pkcs1-sha256-key-encoded-ber.pem");

+ RunTestCase(FAILURE, "rsa-pkcs1-sha256-key-encoded-ber.pem");

}

TEST(VerifySignedDataTest, EcdsaSecp384r1Sha256) {

« no previous file with comments | « net/cert/internal/verify_signed_data.cc ('k') | net/cert/jwk_serializer_openssl.cc » ('j') | no next file with comments »