Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1742853004: Add test client cert w/ SAN fields (Closed)

Created:
4 years, 9 months ago by Kevin Cernekee
Modified:
4 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test client cert that contains two subject alternative names: - one of type otherName, with Microsoft's msUPN type (Active Directory User Principal Name) - one of type rfc822Name (standard email address) This will be used to test wifi authentication on ChromeOS with some forms of Microsoft EAP servers. BUG=549659 TEST=unit test in dependent CL crrev.com/1720653002 Committed: https://crrev.com/7cb77675352911149943650813fd90a7e4a8b528 Cr-Commit-Position: refs/heads/master@{#378652}

Patch Set 1 #

Patch Set 2 : make a new client_3 cert for SAN tests #

Patch Set 3 : update README #

Patch Set 4 : add updated .der files for client_1 / client_2 #

Patch Set 5 : update more platform_keys test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+452 lines, -250 lines) Patch
M chrome/test/data/extensions/api_test/platform_keys/client_1.der View 1 2 3 Binary file 0 comments Download
M chrome/test/data/extensions/api_test/platform_keys/client_1_spki.der View 1 2 3 4 Binary file 0 comments Download
M chrome/test/data/extensions/api_test/platform_keys/client_2.der View 1 2 3 Binary file 0 comments Download
M chrome/test/data/extensions/api_test/platform_keys/signature_nohash_pkcs View 1 2 3 4 Binary file 0 comments Download
M chrome/test/data/extensions/api_test/platform_keys/signature_sha1_pkcs View 1 2 3 4 Binary file 0 comments Download
M net/data/ssl/certificates/README View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M net/data/ssl/certificates/client_1.key View 1 1 chunk +25 lines, -25 lines 0 comments Download
M net/data/ssl/certificates/client_1.pem View 1 2 chunks +50 lines, -50 lines 0 comments Download
M net/data/ssl/certificates/client_1.pk8 View 1 Binary file 0 comments Download
M net/data/ssl/certificates/client_1_ca.pem View 1 2 chunks +49 lines, -49 lines 0 comments Download
M net/data/ssl/certificates/client_2.key View 1 1 chunk +25 lines, -25 lines 0 comments Download
M net/data/ssl/certificates/client_2.pem View 1 2 chunks +50 lines, -50 lines 0 comments Download
M net/data/ssl/certificates/client_2.pk8 View 1 Binary file 0 comments Download
M net/data/ssl/certificates/client_2_ca.pem View 1 2 chunks +49 lines, -49 lines 0 comments Download
A net/data/ssl/certificates/client_3.key View 1 1 chunk +27 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/client_3.pem View 1 1 chunk +70 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/client_3.pk8 View 1 Binary file 0 comments Download
A net/data/ssl/certificates/client_3_ca.pem View 1 1 chunk +71 lines, -0 lines 0 comments Download
M net/data/ssl/scripts/client-certs.cnf View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/data/ssl/scripts/generate-client-certificates.sh View 1 5 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
Kevin Cernekee
4 years, 9 months ago (2016-02-27 19:08:42 UTC) #2
Ryan Sleevi
I would prefer you create new certificates here, to make sure we're testing certificates w/ ...
4 years, 9 months ago (2016-02-28 16:34:53 UTC) #5
Kevin Cernekee
On 2016/02/28 16:34:53, Ryan Sleevi wrote: > I would prefer you create new certificates here, ...
4 years, 9 months ago (2016-02-28 20:45:20 UTC) #6
Ryan Sleevi
Update the README in the /certificates directory and LGTM
4 years, 9 months ago (2016-02-29 21:52:43 UTC) #7
Ryan Sleevi
Also, reworded description to reflect what was done.
4 years, 9 months ago (2016-02-29 21:53:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742853004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742853004/40001
4 years, 9 months ago (2016-02-29 22:48:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/174102)
4 years, 9 months ago (2016-03-01 00:08:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742853004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742853004/40001
4 years, 9 months ago (2016-03-01 19:04:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/174660)
4 years, 9 months ago (2016-03-01 20:29:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742853004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742853004/40001
4 years, 9 months ago (2016-03-01 20:56:19 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/174718)
4 years, 9 months ago (2016-03-01 22:18:05 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742853004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742853004/80001
4 years, 9 months ago (2016-03-02 00:18:21 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-02 02:06:37 UTC) #29
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 02:07:58 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7cb77675352911149943650813fd90a7e4a8b528
Cr-Commit-Position: refs/heads/master@{#378652}

Powered by Google App Engine
This is Rietveld 408576698