Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4029)

Unified Diff: chrome/browser/views/go_button.h

Issue 17428: Issue 358: Can't open a new tab by middle-clicking home button... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/location_bar.h ('k') | chrome/browser/views/go_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/go_button.h
===================================================================
--- chrome/browser/views/go_button.h (revision 12354)
+++ chrome/browser/views/go_button.h (working copy)
@@ -8,7 +8,7 @@
#include "chrome/views/controls/button/image_button.h"
#include "base/task.h"
-class CommandUpdater;
+class Browser;
class LocationBarView;
////////////////////////////////////////////////////////////////////////////////
@@ -26,9 +26,7 @@
class GoButton : public views::ToggleImageButton,
public views::ButtonListener {
public:
- // TODO(beng): get rid of the command updater param and instead have a
- // delegate.
- GoButton(LocationBarView* location_bar, CommandUpdater* command_updater);
+ GoButton(LocationBarView* location_bar, Browser* Browser);
virtual ~GoButton();
typedef enum Mode { MODE_GO = 0, MODE_STOP };
@@ -42,7 +40,7 @@
// Overridden from views::ButtonListener:
virtual void ButtonPressed(views::Button* button);
-
+
// Overridden from views::View:
virtual void OnMouseExited(const views::MouseEvent& e);
virtual bool GetTooltipText(int x, int y, std::wstring* tooltip);
@@ -54,7 +52,7 @@
ScopedRunnableMethodFactory<GoButton> stop_timer_;
LocationBarView* location_bar_;
- CommandUpdater* command_updater_;
+ Browser* browser_;
// The mode we should be in
Mode intended_mode_;
« no previous file with comments | « chrome/browser/location_bar.h ('k') | chrome/browser/views/go_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698