Issue 358: Can't open a new tab by middle-clicking home button...

chrome/browser/views/go_button.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/go_button.h"
 
 #include "chrome/app/chrome_dll_resource.h"
-#include "chrome/browser/command_updater.h"
+#include "chrome/browser/browser.h"
+#include "chrome/browser/views/event_utils.h"
 #include "chrome/browser/views/location_bar_view.h"
 #include "chrome/common/l10n_util.h"
 #include "grit/generated_resources.h"
 
 ////////////////////////////////////////////////////////////////////////////////
 // GoButton, public:
 
-GoButton::GoButton(LocationBarView* location_bar,
-                   CommandUpdater* command_updater)
+GoButton::GoButton(LocationBarView* location_bar, Browser* browser)
     : ToggleImageButton(this),
       location_bar_(location_bar),
-      command_updater_(command_updater),
+      browser_(browser),
       intended_mode_(MODE_GO),
       visible_mode_(MODE_GO),
       button_delay_(NULL),
       stop_timer_(this) {
   DCHECK(location_bar_);
+  set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN |
+                           views::Event::EF_MIDDLE_BUTTON_DOWN);
 }
 
 GoButton::~GoButton() {
   stop_timer_.RevokeAll();
 }
 
 void GoButton::ChangeMode(Mode mode) {
   stop_timer_.RevokeAll();
 
   SetToggled(mode == MODE_STOP);
@@ skipping 21 matching lines @@
       ChangeMode(MODE_GO);
     }
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // GoButton, views::ButtonListener implementation:
 
 void GoButton::ButtonPressed(views::Button* button) {
   if (visible_mode_ == MODE_STOP) {
-    command_updater_->ExecuteCommand(IDC_STOP);
+    browser_->Stop();
 
     // The user has clicked, so we can feel free to update the button,
     // even if the mouse is still hovering.
     ChangeMode(MODE_GO);
   } else if (visible_mode_ == MODE_GO && stop_timer_.empty()) {
     // If the go button is visible and not within the double click timer, go.
-    command_updater_->ExecuteCommand(IDC_GO);
+    browser_->Go(event_utils::DispositionFromEventFlags(mouse_event_flags()));
 
     // Figure out the system double-click time.
     if (button_delay_ == NULL)
       button_delay_ = GetDoubleClickTime();
 
     // Stop any existing timers.
     stop_timer_.RevokeAll();
 
     // Start a timer - while this timer is running, the go button
     // cannot be changed to a stop button. We do not set intended_mode_
@@ skipping 52 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // GoButton, private:
 
 void GoButton::OnButtonTimer() {
   if (intended_mode_ != visible_mode_)
     ChangeMode(intended_mode_);
 
   stop_timer_.RevokeAll();
 }