Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1742763003: [sqlite] Pull out recent recover.c changes into new patch. (Closed)

Created:
4 years, 10 months ago by Scott Hess - ex-Googler
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@zzsql_patch_icu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sqlite] Pull out recent recover.c changes into new patch. Pull the changes to make recover.c work without SQLite internals into the recover patch. The changes are not quite complete, but other changes being made to third_party/sqlite/ run the risk of losing the in-progress patches. After change, google_generate_amalgamation.sh generated identical sqlite3.c output. BUG=584407 TBR=rch@chromium.org Committed: https://crrev.com/ee29289c53effb24d9d653afeed75d99c82df0fc Cr-Commit-Position: refs/heads/master@{#378013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -114 lines) Patch
M third_party/sqlite/patches/0005-Virtual-table-supporting-recovery-of-corrupted-datab.patch View 32 chunks +245 lines, -114 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
Scott Hess - ex-Googler
No change to build, this just pulls out the previous changes to the patch file ...
4 years, 10 months ago (2016-02-26 19:19:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742763003/1
4 years, 10 months ago (2016-02-26 20:26:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/28399)
4 years, 10 months ago (2016-02-26 20:54:46 UTC) #7
Scott Hess - ex-Googler
On 2016/02/26 20:54:46, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-26 22:16:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742763003/1
4 years, 10 months ago (2016-02-26 22:18:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 22:54:12 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 22:55:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee29289c53effb24d9d653afeed75d99c82df0fc
Cr-Commit-Position: refs/heads/master@{#378013}

Powered by Google App Engine
This is Rietveld 408576698