Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 17426004: Minor cosmetic changes to OmniboxEditModel and OmniboxController. (Closed)

Created:
7 years, 6 months ago by beaudoin
Modified:
7 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Minor cosmetic changes to OmniboxEditModel and OmniboxController. This follow-up on some late comments by pkasting on https://codereview.chromium.org/14698028 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207429

Patch Set 1 #

Total comments: 4

Patch Set 2 : Answered Peter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M chrome/browser/autocomplete/autocomplete_result.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
beaudoin
Fixing the nits on the previous CL.
7 years, 6 months ago (2013-06-18 22:38:44 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/17426004/diff/1/chrome/browser/autocomplete/autocomplete_result.cc File chrome/browser/autocomplete/autocomplete_result.cc (right): https://codereview.chromium.org/17426004/diff/1/chrome/browser/autocomplete/autocomplete_result.cc#newcode137 chrome/browser/autocomplete/autocomplete_result.cc:137: alternate_nav_url_ = default_match_ == end() ? Nit: Parens ...
7 years, 6 months ago (2013-06-18 23:31:19 UTC) #2
beaudoin
https://codereview.chromium.org/17426004/diff/1/chrome/browser/autocomplete/autocomplete_result.cc File chrome/browser/autocomplete/autocomplete_result.cc (right): https://codereview.chromium.org/17426004/diff/1/chrome/browser/autocomplete/autocomplete_result.cc#newcode137 chrome/browser/autocomplete/autocomplete_result.cc:137: alternate_nav_url_ = default_match_ == end() ? On 2013/06/18 23:31:19, ...
7 years, 6 months ago (2013-06-19 18:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/17426004/6001
7 years, 6 months ago (2013-06-19 18:22:10 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-19 18:59:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/17426004/6001
7 years, 6 months ago (2013-06-19 19:01:21 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 14:09:14 UTC) #7
Message was sent while issue was closed.
Change committed as 207429

Powered by Google App Engine
This is Rietveld 408576698