Revert of Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace

Revert of Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace (patchset #3 id:40001 of https://codereview.chromium.org/1733193002/ )

Reason for revert:
It seems to break chromeos=1, not only buildtype official. Reverting and will start discussing an agreeable solution on chrome-dev.

Original issue's description:
> Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace
>
> Together with Behdad we identified several ways to optimize and cleanup
> HarfBuzzFace:
> * We moved the glyph lookup completely to the built-in HarfBuzz
>   implementation in hb-ot-font.
> * This allows us to remove the unbounded glyph cache we kept around in
>   HarfBuzzFace.
> * We also moved instantantion and ownership of HarfBuzzFontData to
>   HarfBuzzFace. We only update the size and unicode-range on each call
>   to getScaledFont(), saving us as the allocation and setup costs of
>   this object for each shaping call.
> * We removed the unneeded callback for retrieving the horizontal origin,
>   which was implemented as a noop.
>
> In local measurements on Mac this leads to large improvements in the
> blink_perf.layout tests, especially in
> chapter-reflow-once-random (>130%), flexbox-lots-of-data (>58%) and
> ArabicLineLayout (>26%) with only a few of the microbenchmarks being
> slightly slower: So this is an improvement for layout cases that do not
> profit much from the word cache.
>
> Note to ChromeOS developers: If this change breaks your workflow linking
> release builds with system HarfBuzz because of an old version of
> HarfBuzz on the host system, we recommend to install and apt-pin the
> same version of the HarfBuzz library on your host system that ChromeOS
> uses. Please see bug 589342.
>
> BUG=589340
> R=eae,behdad,kojii
>
> Committed: https://crrev.com/85a2c1c0597a31b043e58fe4a4ce00a88ebc0684
> Cr-Commit-Position: refs/heads/master@{#377849}

TBR=kojii@chromium.org,behdad@chromium.org,eae@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589340
Committed: https://crrev.com/11a49499bbe6dde86daf65fc9244ce931a6b94ca
Cr-Commit-Position: refs/heads/master@{#377867}

[drott, 2016-02-26 11:12:23]

Created Revert of Move glyph lookup to hb-ot-font and remove glyph cache in
HarfBuzzFace

[commit-bot: I haz the power, 2016-02-26 11:12:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1742593003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1742593003/1

[commit-bot: I haz the power, 2016-02-26 11:13:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-26 11:15:24]

Description was changed from

==========
Revert of Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace
(patchset #3 id:40001 of https://codereview.chromium.org/1733193002/ )

Reason for revert:
It seems to break chromeos=1, not only buildtype official. Reverting and will
start discussing an agreeable solution on chrome-dev.

Original issue's description:
> Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace
> 
> Together with Behdad we identified several ways to optimize and cleanup
> HarfBuzzFace:
> * We moved the glyph lookup completely to the built-in HarfBuzz
>   implementation in hb-ot-font.
> * This allows us to remove the unbounded glyph cache we kept around in
>   HarfBuzzFace.
> * We also moved instantantion and ownership of HarfBuzzFontData to
>   HarfBuzzFace. We only update the size and unicode-range on each call
>   to getScaledFont(), saving us as the allocation and setup costs of
>   this object for each shaping call.
> * We removed the unneeded callback for retrieving the horizontal origin,
>   which was implemented as a noop.
> 
> In local measurements on Mac this leads to large improvements in the
> blink_perf.layout tests, especially in
> chapter-reflow-once-random (>130%), flexbox-lots-of-data (>58%) and
> ArabicLineLayout (>26%) with only a few of the microbenchmarks being
> slightly slower: So this is an improvement for layout cases that do not
> profit much from the word cache.
> 
> Note to ChromeOS developers: If this change breaks your workflow linking
> release builds with system HarfBuzz because of an old version of
> HarfBuzz on the host system, we recommend to install and apt-pin the
> same version of the HarfBuzz library on your host system that ChromeOS
> uses. Please see bug 589342.
> 
> BUG=589340
> R=eae,behdad,kojii
> 
> Committed: https://crrev.com/85a2c1c0597a31b043e58fe4a4ce00a88ebc0684
> Cr-Commit-Position: refs/heads/master@{#377849}

TBR=kojii@chromium.org,behdad@chromium.org,eae@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589340
==========

to

==========
Revert of Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace
(patchset #3 id:40001 of https://codereview.chromium.org/1733193002/ )

Reason for revert:
It seems to break chromeos=1, not only buildtype official. Reverting and will
start discussing an agreeable solution on chrome-dev.

Original issue's description:
> Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace
>
> Together with Behdad we identified several ways to optimize and cleanup
> HarfBuzzFace:
> * We moved the glyph lookup completely to the built-in HarfBuzz
>   implementation in hb-ot-font.
> * This allows us to remove the unbounded glyph cache we kept around in
>   HarfBuzzFace.
> * We also moved instantantion and ownership of HarfBuzzFontData to
>   HarfBuzzFace. We only update the size and unicode-range on each call
>   to getScaledFont(), saving us as the allocation and setup costs of
>   this object for each shaping call.
> * We removed the unneeded callback for retrieving the horizontal origin,
>   which was implemented as a noop.
>
> In local measurements on Mac this leads to large improvements in the
> blink_perf.layout tests, especially in
> chapter-reflow-once-random (>130%), flexbox-lots-of-data (>58%) and
> ArabicLineLayout (>26%) with only a few of the microbenchmarks being
> slightly slower: So this is an improvement for layout cases that do not
> profit much from the word cache.
>
> Note to ChromeOS developers: If this change breaks your workflow linking
> release builds with system HarfBuzz because of an old version of
> HarfBuzz on the host system, we recommend to install and apt-pin the
> same version of the HarfBuzz library on your host system that ChromeOS
> uses. Please see bug 589342.
>
> BUG=589340
> R=eae,behdad,kojii
>
> Committed: https://crrev.com/85a2c1c0597a31b043e58fe4a4ce00a88ebc0684
> Cr-Commit-Position: refs/heads/master@{#377849}

TBR=kojii@chromium.org,behdad@chromium.org,eae@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589340

Committed: https://crrev.com/11a49499bbe6dde86daf65fc9244ce931a6b94ca
Cr-Commit-Position: refs/heads/master@{#377867}
==========

[commit-bot: I haz the power, 2016-02-26 11:15:25]

Patchset 1 (id:??) landed as
https://crrev.com/11a49499bbe6dde86daf65fc9244ce931a6b94ca
Cr-Commit-Position: refs/heads/master@{#377867}