Issue 174254: Some tweaks to the OS X Sandbox:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174254: Some tweaks to the OS X Sandbox: (Closed)

Created:
11 years, 4 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
Paul Godavari

CC:
chromium-reviews_googlegroups.com, Amanda Walker, John Grabowski

Visibility:
Public.

Description

Some tweaks to the OS X Sandbox: * Fix 10.6 bug where garbled text was displayed due to insuccesful font loading. * Tightened down the Sandbox a bit, instead of allowing access to /System/Library limit it to certain subdirectories. * Remove unused warmup code now that we allow sysctl-read. BUG=11269 BUG=b/1853366 TEST=On 10.6, copy Arial.ttf from /System/Library/Fonts to ~/Library/Fonts , Launch Chrome. Text on NTP should be displayed normally and not garbled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24030

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -36 lines)			Patch
M	base/sys_info_mac.cc	View	1 chunk	+3 lines, -12 lines	0 comments	Download
M	chrome/renderer/renderer.sb	View	1 chunk	+12 lines, -6 lines	0 comments	Download
M	chrome/renderer/renderer_main_platform_delegate_mac.mm	View	2 chunks	+21 lines, -18 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul Godavari

11 years, 4 months ago (2009-08-21 21:26:12 UTC) #2

LGTM

http://codereview.chromium.org/174254/diff/1/4
File chrome/renderer/renderer_main_platform_delegate_mac.mm (right):

http://codereview.chromium.org/174254/diff/1/4#newcode118
Line 118: NSString *sandbox_data = [NSString
nit: * should be placed consistently.

Expand Messages | Collapse Messages