Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1742443003: input[type=datetime-local], input[type=month] and input[type=week] warn if a specified value is an … (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

input[type=datetime-local], input[type=month] and input[type=week] warn if a specified value is an invalid string. We show console messages like the followings: The specified value "ABC" does not conform to the required format. The format is "yyyy-MM-ddThh:mm" followed by optional ":ss" or ":ss.SSS". The specified value "ABC" does not conform to the required format. The format is "yyyy-MM" where yyyy is year in four or more digits, and MM is 01-12. The specified value "2012-12-24" does not conform to the required format. The format is "yyyy-Www" where yyyy is year in four or more digits, and ww is 01-53. BUG=397952 Committed: https://crrev.com/217c05d53024c7053dd07fcda871b7252b47cdcf Cr-Commit-Position: refs/heads/master@{#377828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/datetimelocal/datetimelocal-pseudo-classes-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/month/month-pseudo-classes-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/week/week-pseudo-classes-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/the-input-element/month-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/DateTimeLocalInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/DateTimeLocalInputType.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/MonthInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/MonthInputType.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/WeekInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/WeekInputType.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Keishi, would you review this please?
4 years, 9 months ago (2016-02-26 04:58:17 UTC) #2
keishi
LGTM
4 years, 9 months ago (2016-02-26 05:01:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742443003/1
4 years, 9 months ago (2016-02-26 05:58:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-26 06:10:39 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 06:12:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/217c05d53024c7053dd07fcda871b7252b47cdcf
Cr-Commit-Position: refs/heads/master@{#377828}

Powered by Google App Engine
This is Rietveld 408576698