Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174243003: add SkCanvas::drawDRRect (Closed)

Created:
6 years, 10 months ago by reed1
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add SkCanvas::drawDRRect BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13524

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : augment is_drawing_op predicate #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : address comments from #3 #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -3 lines) Patch
A gm/drrect.cpp View 1 2 3 4 1 chunk +69 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkBBoxRecord.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBBoxRecord.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 chunks +41 lines, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 4 4 chunks +26 lines, -2 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
early upload for API -- am working on gm now
6 years, 10 months ago (2014-02-20 19:43:16 UTC) #1
robertphillips
https://codereview.chromium.org/174243003/diff/1/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/174243003/diff/1/src/core/SkCanvas.cpp#newcode1765 src/core/SkCanvas.cpp:1765: kDRRect_Type?
6 years, 10 months ago (2014-02-20 19:47:46 UTC) #2
bsalomon
api lgtm
6 years, 10 months ago (2014-02-20 19:47:54 UTC) #3
humper
On 2014/02/20 19:47:54, bsalomon wrote: > api lgtm LGTM, although technically the shape is an ...
6 years, 10 months ago (2014-02-20 20:18:27 UTC) #4
reed1
On 2014/02/20 20:18:27, humper wrote: > On 2014/02/20 19:47:54, bsalomon wrote: > > api lgtm ...
6 years, 10 months ago (2014-02-20 20:28:18 UTC) #5
robertphillips
lgtm + nits https://codereview.chromium.org/174243003/diff/120001/gm/drrect.cpp File gm/drrect.cpp (right): https://codereview.chromium.org/174243003/diff/120001/gm/drrect.cpp#newcode17 gm/drrect.cpp:17: protected: override on following methods? https://codereview.chromium.org/174243003/diff/120001/src/core/SkPictureRecord.cpp ...
6 years, 10 months ago (2014-02-20 20:33:31 UTC) #6
reed1
https://codereview.chromium.org/174243003/diff/120001/gm/drrect.cpp File gm/drrect.cpp (right): https://codereview.chromium.org/174243003/diff/120001/gm/drrect.cpp#newcode17 gm/drrect.cpp:17: protected: On 2014/02/20 20:33:31, robertphillips wrote: > override on ...
6 years, 10 months ago (2014-02-20 20:47:01 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-21 01:07:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/174243003/230001
6 years, 10 months ago (2014-02-21 01:07:07 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 02:32:44 UTC) #10
Message was sent while issue was closed. 
Change committed as 13524

Powered by Google App Engine
This is Rietveld 408576698