Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1742403002: Fix git recipe module to use git.bad as package resouce. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix git recipe module to use git.bad as package resouce. R=phajdan.jr@chromium.org BUG=579160 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M recipe_modules/git/api.py View 2 chunks +2 lines, -3 lines 0 comments Download
M recipe_modules/git/example.expected/platform_win.json View 15 chunks +16 lines, -16 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_wrong_patch.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742403002/1
4 years, 9 months ago (2016-02-29 17:27:10 UTC) #2
tandrii(chromium)
4 years, 9 months ago (2016-02-29 17:27:10 UTC) #3
Paweł Hajdan Jr.
LGTM
4 years, 9 months ago (2016-02-29 17:28:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742403002/1
4 years, 9 months ago (2016-02-29 17:28:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299005
4 years, 9 months ago (2016-02-29 17:29:24 UTC) #9
tandrii(chromium)
4 years, 9 months ago (2016-02-29 19:40:58 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1750733002/ by tandrii@chromium.org.

The reason for reverting is: broke win builder bug 590806.

Powered by Google App Engine
This is Rietveld 408576698