Added test to verify that onmostvisitedchange event is dispatched when an user navigate from SRP to…

chrome/browser/ui/search/instant_extended_interactive_uitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_base.h"
 #include "base/metrics/histogram_samples.h"
@@ skipping 2879 matching lines @@
   browser()->tab_strip_model()->ActivateTabAt(0, false);
 
   // Switch back to new tab.
   browser()->tab_strip_model()->ActivateTabAt(1, false);
 
   // Confirm that new tab got no onmostvisitedchanged event.
   active_tab = browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_TRUE(UpdateSearchState(active_tab));
   EXPECT_EQ(2, on_most_visited_change_calls_);
 }
+
+// Flaky on Windows and Mac try bots.

[Jered, 2013/06/19 22:26:45]

What is this actually testing on OS_LINUX? Does that include ChromeOS?
InstantExtended doesn't really work on linux, right?

[kmadhusu, 2013/06/21 17:34:54]

Changed OS_LINUX to OS_CHROMEOS. 

OS_LINUX include OS_CHROMEOS. 

kEnableInstantExtendedAPI is enabled for testing on all platforms (Ref:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...).
 We removed linux support for instant extended flags (crrev.com/16408023). In
other words, we no longer list these flags in the about://flags page on
OS_LINUX. But these tests can very well run on OS_LINUX. 

+#if defined(OS_LINUX)
+#define MAYBE_DispatchMVChangeEventWhileNavigatingBackToNTP DispatchMVChangeEventWhileNavigatingBackToNTP
+#else
+#define MAYBE_DispatchMVChangeEventWhileNavigatingBackToNTP DISABLED_DispatchMVChangeEventWhileNavigatingBackToNTP
+#endif
+IN_PROC_BROWSER_TEST_F(InstantExtendedTest,
+                       MAYBE_DispatchMVChangeEventWhileNavigatingBackToNTP) {
+  // Setup Instant.
+  ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
+  FocusOmniboxAndWaitForInstantOverlayAndNTPSupport();
+
+  // Open new tab. Preloaded NTP contents should have been used.
+  ui_test_utils::NavigateToURLWithDisposition(
+      browser(),
+      GURL(chrome::kChromeUINewTabURL),
+      NEW_FOREGROUND_TAB,
+      ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);
+
+  content::WebContents* active_tab =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  EXPECT_TRUE(UpdateSearchState(active_tab));
+  EXPECT_EQ(2, on_most_visited_change_calls_);
+
+  content::WindowedNotificationObserver observer(
+      content::NOTIFICATION_LOAD_STOP,
+      content::NotificationService::AllSources());
+  // Set the text and press enter to navigate from NTP.
+  SetOmniboxText("Pen");
+  PressEnterAndWaitForNavigation();
+  EXPECT_EQ(ASCIIToUTF16("Pen"), omnibox()->GetText());
+  observer.Wait();
+
+  // Navigate back to NTP.
+  content::WindowedNotificationObserver back_observer(
+      content::NOTIFICATION_LOAD_STOP,
+      content::NotificationService::AllSources());
+  active_tab = browser()->tab_strip_model()->GetActiveWebContents();
+  EXPECT_TRUE(active_tab->GetController().CanGoBack());
+  active_tab->GetController().GoBack();
+  back_observer.Wait();
+
+  // Verify that onmostvisitedchange event is dispatched when we navigate from
+  // SRP to NTP.
+  active_tab = browser()->tab_strip_model()->GetActiveWebContents();
+  EXPECT_TRUE(UpdateSearchState(active_tab));
+  EXPECT_EQ(2, on_most_visited_change_calls_);
+}