Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: tools/perf/page_sets/top_pages.py

Issue 1742363002: Only use new login flow for GmailSmoothPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/top_25_smooth.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/top_pages.py
diff --git a/tools/perf/page_sets/top_pages.py b/tools/perf/page_sets/top_pages.py
index 2bee2699e535fcf12ebe512d491e2f6167497e8f..7f0d187b3d427b74e1b6d6e1a8b5456302c69484 100644
--- a/tools/perf/page_sets/top_pages.py
+++ b/tools/perf/page_sets/top_pages.py
@@ -4,8 +4,6 @@
from telemetry.page import page as page_module
from telemetry.page import shared_page_state
-from page_sets.login_helpers import google_login
-
class TopPages(page_module.Page):
@@ -56,16 +54,14 @@ class GmailPage(TopPages):
super(GmailPage, self).__init__(
url='https://mail.google.com/mail/',
page_set=page_set,
+ credentials='google',
shared_page_state_class=shared_page_state_class)
def RunNavigateSteps(self, action_runner):
- google_login.LoginGoogleAccount(action_runner, 'google3',
- self.credentials_path)
super(GmailPage, self).RunNavigateSteps(action_runner)
action_runner.WaitForJavaScriptCondition(
'window.gmonkey !== undefined &&'
- 'document.getElementById("gb") !== null',
- timeout_in_seconds=120)
+ 'document.getElementById("gb") !== null')
class GoogleCalendarPage(TopPages):
« no previous file with comments | « tools/perf/page_sets/top_25_smooth.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698