Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1742333002: PPC: [compiler] Drop the CompareNilIC. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [compiler] Drop the CompareNilIC. Port fb59ea3334bef0f4d2a1dd4b579bf5eec3bc1f35 Original commit message: Since both null and undefined are also marked as undetectable now, we can just test that bit instead of having the CompareNilIC try to collect feedback to speed up the general case (without the undetectable bit being used). Drive-by-fix: Update the type system to match the new handling of undetectable in the runtime. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/0a287e230b9f5503f9edca827d1e7770a5849a5b Cr-Commit-Position: refs/heads/master@{#34371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 9 months ago (2016-02-29 15:56:02 UTC) #1
JoranSiu
On 2016/02/29 15:56:02, MTBrandyberry wrote: lgtm
4 years, 9 months ago (2016-02-29 19:45:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742333002/1
4 years, 9 months ago (2016-02-29 19:45:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16224)
4 years, 9 months ago (2016-02-29 19:50:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742333002/1
4 years, 9 months ago (2016-02-29 20:14:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 20:27:41 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 20:28:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a287e230b9f5503f9edca827d1e7770a5849a5b
Cr-Commit-Position: refs/heads/master@{#34371}

Powered by Google App Engine
This is Rietveld 408576698