Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/gn/label_unittest.cc

Issue 1742303002: Accept absolute Windows paths without leading slash in GN commands (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/label_pattern_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/label_unittest.cc
diff --git a/tools/gn/label_unittest.cc b/tools/gn/label_unittest.cc
index 37c097f23224e52e92598ab9eae44907a84ab5d2..f4bfc07a1543c67aa4a9da9f79621aab988f1d26 100644
--- a/tools/gn/label_unittest.cc
+++ b/tools/gn/label_unittest.cc
@@ -40,7 +40,7 @@ TEST(Label, Resolve) {
#if defined(OS_WIN)
{ "//chrome/", "/C:/chrome:bar", true , "/C:/chrome/", "bar", "//t/", "d" },
{ "//chrome/", "/C:/chrome/:bar", true, "/C:/chrome/", "bar", "//t/", "d" },
- { "//chrome/", "C:/chrome:bar", false, "", "", "", "" },
+ { "//chrome/", "C:/chrome:bar", true, "/C:/chrome/", "bar", "//t/", "d" },
brettw 2016/04/05 00:01:57 Can you add a test here that "C:foo" is parsed as
#endif
// Refers to root dir.
{ "//chrome/", "//:bar", true, "//", "bar", "//t/", "d" },
« no previous file with comments | « tools/gn/label_pattern_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698