Make sure USE_SYMBOLIZE is propagated to base_unittests.

Make sure USE_SYMBOLIZE is properly set in base_unittests.

BUG=248768
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208994

[jar (doing other things), 2013-06-26 21:03:04]

Passing to Mark, who may be more familiar with this.

[Mark Mentovai, 2013-06-26 21:20:03]

direct_dependent_settings is useful where a header is exposed to other targets
and makes use of a certain macro. That’s not the case here. USE_SYMBOLIZE is an
implementation detail internal to base, and incidentally one of its unit tests
also uses the macro.

You don’t want to expose USE_SYMBOLIZE to all consumers of base.

You do want to either define USE_SYMBOLIZE for base_unittests, or rewrite the
#ifdef in base/debug/stack_trace_unittest.cc to use some other condition for
enabling that EXPECT.

[Paweł Hajdan Jr., 2013-06-27 18:42:57]

PTAL

[Mark Mentovai, 2013-06-27 19:39:36]

LGTM, but fix the change description, it’s not “propagating” anymore.

[Paweł Hajdan Jr., 2013-06-27 20:39:42]

On 2013/06/27 19:39:36, Mark Mentovai wrote:
> LGTM, but fix the change description, it’s not “propagating” anymore.

Done, thank you for also reviewing the commit message.

Note: I didn't change the Rietveld summary so that e-mails will continue to be
sanely threaded. This has no effect on the commit message.

[Paweł Hajdan Jr., 2013-06-27 20:41:43]

Committed patchset #2 manually as r208994 (presubmit successful).