Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1742293003: Remove isolated app code from iOS's chrome_browser_state_io_data. (Closed)

Created:
4 years, 9 months ago by mmenke
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove isolated app code from iOS's chrome_browser_state_io_data. Chrome for iOS doesn't have isolated apps, so it's just dead code. BUG=none

Patch Set 1 #

Patch Set 2 : Fix stuff #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -307 lines) Patch
M ios/chrome/browser/browser_state/chrome_browser_state.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.h View 1 4 chunks +1 line, -11 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm View 1 5 chunks +1 line, -82 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.h View 4 chunks +0 lines, -34 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 4 chunks +0 lines, -77 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm View 1 chunk +0 lines, -14 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.mm View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state_isolated_context.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state_isolated_context.mm View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M ios/chrome/browser/net/ios_chrome_url_request_context_getter.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/net/ios_chrome_url_request_context_getter.cc View 1 2 chunks +0 lines, -36 lines 0 comments Download

Depends on Patchset:

Issue 1748673002 Patch 1

Messages

Total messages: 1 (1 generated)
mmenke
4 years, 9 months ago (2016-02-29 17:19:27 UTC) #1 
Description was changed from

==========
Remove isolated app code from iOS's chrome_browser_state_io_data.

Chrome for iOS doesn't have isolated apps, so it's just dead code.

BUG=none
==========

to

==========
Remove isolated app code from iOS's chrome_browser_state_io_data.

Chrome for iOS doesn't have isolated apps, so it's just dead code.

BUG=none
==========

Powered by Google App Engine
This is Rietveld 408576698