Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1742293002: Support src/build/linux/unbundle in CharacterDataGenerator (Closed)

Created:
4 years, 9 months ago by kojii
Modified:
4 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support src/build/linux/unbundle in CharacterDataGenerator This patch fixes CharacterDataGenerator introduced in crrev.com/371917 to work with src/build/linux/unbundle/replace_gyp_files.py, which some distributors rely on. UTrie2 in ICU is not available in that configuration. UnicodeSet is available in all configurations and can provide similar functionalities, but it is slower than UTrie2 by ~80% and consumes slightly more private memory. It is still faster than the original hand-written code though. This patch uses UnicodeSet in such configurations while uses UTrie2 in other configurations. BUG=584920 Committed: https://crrev.com/322d747a84c09485347813fe5863db140e790e4b Cr-Commit-Position: refs/heads/master@{#378253}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -365 lines) Patch
M third_party/WebKit/Source/platform/fonts/Character.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Character.cpp View 1 5 chunks +38 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/fonts/CharacterData.h View 1 4 chunks +10 lines, -123 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/CharacterDataGenerator.cpp View 1 4 chunks +32 lines, -236 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kojii
PTAL. Another option is to switch to UnicodeSet on all configurations, if you think the ...
4 years, 9 months ago (2016-02-29 15:13:35 UTC) #5
eae
LGTM
4 years, 9 months ago (2016-02-29 18:25:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742293002/20001
4 years, 9 months ago (2016-02-29 20:06:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 20:12:15 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 20:13:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/322d747a84c09485347813fe5863db140e790e4b
Cr-Commit-Position: refs/heads/master@{#378253}

Powered by Google App Engine
This is Rietveld 408576698