Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1742283002: Move hasOwnProperty to builtins.cc (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move hasOwnProperty to builtins.cc This gets rid of the JavaScript wrapper. That way we can more quickly handle non-JSReceivers and indexed properties; and don't need to optimize the JavaScript wrapper either. BUG= Committed: https://crrev.com/d5cb0ce4e908ae5b447ab1e3396219357ee7f73c Cr-Commit-Position: refs/heads/master@{#34356}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -102 lines) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -0 lines 1 comment Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M src/js/i18n.js View 8 chunks +10 lines, -9 lines 0 comments Download
M src/js/macros.py View 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/messages.js View 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +1 line, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -79 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742283002/1
4 years, 9 months ago (2016-02-29 08:38:58 UTC) #2
Toon Verwaest
ptal
4 years, 9 months ago (2016-02-29 08:44:01 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1742283002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1742283002/diff/1/src/bootstrapper.cc#newcode1126 src/bootstrapper.cc:1126: Builtins::kObjectHasOwnProperty, 1, false); Please install the function on the ...
4 years, 9 months ago (2016-02-29 08:46:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 09:08:09 UTC) #7
Toon Verwaest
I unfortunately cannot since the receiver needs to be passed in, and %has_own_property would have ...
4 years, 9 months ago (2016-02-29 10:48:18 UTC) #8
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-02-29 10:50:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742283002/1
4 years, 9 months ago (2016-02-29 10:52:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 10:54:29 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 10:55:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5cb0ce4e908ae5b447ab1e3396219357ee7f73c
Cr-Commit-Position: refs/heads/master@{#34356}

Powered by Google App Engine
This is Rietveld 408576698