Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174223004: linux_aura: Default to system titlebars under some window managers. (Closed)

Created:
6 years, 10 months ago by Elliot Glaysher
Modified:
6 years, 10 months ago
Reviewers:
msw, sadrul, Matt Giuca
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Default to system titlebars under some window managers. This moves the existing window manager check in BrowserWindowGtk to shared X11 code. BUG=317859 R=mgiuca@chromium.org, msw@chromium.org, sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252586

Patch Set 1 #

Patch Set 2 : Add ifdefs. #

Total comments: 2

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -29 lines) Patch
M chrome/browser/ui/browser_view_prefs.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 2 chunks +1 line, -22 lines 0 comments Download
M ui/base/x/x11_util.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Elliot Glaysher
6 years, 10 months ago (2014-02-20 21:08:17 UTC) #1
Matt Giuca
LGTM. Thanks for doing this!
6 years, 10 months ago (2014-02-20 23:13:44 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 10 months ago (2014-02-20 23:27:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/174223004/20006
6 years, 10 months ago (2014-02-20 23:30:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 23:40:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-20 23:40:50 UTC) #6
Elliot Glaysher
msw: c/b/u stamp sadrul: ui/ stamp
6 years, 10 months ago (2014-02-20 23:43:56 UTC) #7
sadrul
LGTM https://codereview.chromium.org/174223004/diff/20006/ui/base/x/x11_util.h File ui/base/x/x11_util.h (right): https://codereview.chromium.org/174223004/diff/20006/ui/base/x/x11_util.h#newcode227 ui/base/x/x11_util.h:227: // Determine whether we use should default to ...
6 years, 10 months ago (2014-02-21 01:21:06 UTC) #8
msw
lgtm with my nit and Sadrul's nit addressed. https://codereview.chromium.org/174223004/diff/20006/ui/base/x/x11_util.cc File ui/base/x/x11_util.cc (right): https://codereview.chromium.org/174223004/diff/20006/ui/base/x/x11_util.cc#newcode1034 ui/base/x/x11_util.cc:1034: nit: ...
6 years, 10 months ago (2014-02-21 01:37:17 UTC) #9
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 10 months ago (2014-02-21 01:42:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/174223004/250001
6 years, 10 months ago (2014-02-21 01:45:23 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 02:45:01 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_rel_device_ninja for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device_ninja&number=2948
6 years, 10 months ago (2014-02-21 02:45:02 UTC) #13
Elliot Glaysher
6 years, 10 months ago (2014-02-21 17:39:17 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 manually as r252586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698