Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/browser/gtk/browser_window_gtk.h

Issue 174215: Fix issue 19785: Chrome enters full-screen mode when a maximized window is mo... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/browser_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_window_gtk.h
===================================================================
--- chrome/browser/gtk/browser_window_gtk.h (revision 23948)
+++ chrome/browser/gtk/browser_window_gtk.h (working copy)
@@ -376,6 +376,22 @@
// The accelerator group used to handle accelerators, owned by this object.
GtkAccelGroup* accel_group_;
+ // Whether SetFullscreen(true) was called, indicating if we really want to be
+ // in fullscreen mode. We should only be in fullscreen mode when both
+ // |set_fullscreen_| and (|state_| & GDK_WWINDOW_STATE_FULLSCREEN) are true,
+ // because following situations might occur:
+ // 1. Window Manager doesn't support fullscreen mode, so that
+ // (|state_| & GDK_WWINDOW_STATE_FULLSCREEN) will always be false.
+ // 2. Window Manager may turn our window into fullscreen mode automatically,
+ // when we do not really want.
+ bool set_fullscreen_;
+
+ // Indicates if we are really in fullscreen mode, that's both
+ // |set_fullscreen_| and (|state_| & GDK_WWINDOW_STATE_FULLSCREEN) are true.
+ // We track it instead of checking above two values every time to make sure we
+ // only do interface adjustment when necessary.
+ bool fullscreen_;
+
DISALLOW_COPY_AND_ASSIGN(BrowserWindowGtk);
};
« no previous file with comments | « no previous file | chrome/browser/gtk/browser_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698