Fix issue 19785: Chrome enters full-screen mode when a maximized window is mo...

Fix issue 19785: Chrome enters full-screen mode when a maximized window is moved to another screen

This CL fixes issue 19785 by recording fullscreen state of the browser window.
If Window Manager wants to turn the browser window into fullscreen mode automatically without our request, then we refuse to change.

However, this CL causes a side effect: some time, the window may be refreshed twice when maximizing the window.

BUG=19785
: Chrome enters full-screen mode when a maximized window is moved to another screen
TEST=Turn off system window decoration, move chrome window to the second monitor then maximize the window to see if the window is maximized instead of entering the full screen mode.

[James Su, 2009-08-21 10:07:45]

Hi,
  It's a CL to fix issue 19785.

[tony, 2009-08-21 17:23:29]

I don't think we want to do this.  There are plenty of valid cases where the
window manager or some other app will try to full screen the window.  I don't
think we want to block these use cases.

For example, ion3 has a key binding (mod1+enter) that toggles full screen mode. 
You could also imagine a window manager having a full screen option in the
titlebar context menu.  These should continue to work.

[use derat at chromium.org, 2009-08-21 17:29:46]

I agree.  I think that this would cause additional bugs (but this
time, with window managers that are doing things correctly).  The
right way to resolve issues like this is by fixing the window manager
(and it sounds like this one might already be fixed in later
versions).

On Fri, Aug 21, 2009 at 10:23 AM, <tony@chromium.org> wrote:
> I don't think we want to do this. =A0There are plenty of valid cases wher=
e
> the window manager or some other app will try to full screen the window.
> =A0I don't think we want to block these use cases.
>
> For example, ion3 has a key binding (mod1+enter) that toggles full
> screen mode. =A0You could also imagine a window manager having a full
> screen option in the titlebar context menu. =A0These should continue to
> work.
>
> http://codereview.chromium.org/174215
>

[James Su, 2009-08-22 00:26:40]

Agree. I have the same concern about this CL :-)

Regards
James Su

On 2009/08/21 17:29:46, derat wrote:
> I agree.  I think that this would cause additional bugs (but this
> time, with window managers that are doing things correctly).  The
> right way to resolve issues like this is by fixing the window manager
> (and it sounds like this one might already be fixed in later
> versions).
> 
> On Fri, Aug 21, 2009 at 10:23 AM, <mailto:tony@chromium.org> wrote:
> > I don't think we want to do this. =A0There are plenty of valid cases wher=
> e
> > the window manager or some other app will try to full screen the window.
> > =A0I don't think we want to block these use cases.
> >
> > For example, ion3 has a key binding (mod1+enter) that toggles full
> > screen mode. =A0You could also imagine a window manager having a full
> > screen option in the titlebar context menu. =A0These should continue to
> > work.
> >
> > http://codereview.chromium.org/174215
> >