Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174213003: PPAPI: Use clang-format on ppapi/shared_impl (Closed)

Created:
6 years, 10 months ago by dmichael (off chromium)
Modified:
6 years, 10 months ago
Reviewers:
teravest
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, dcheng, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

PPAPI: Use clang-format on ppapi/shared_impl This does not yet add the presubmit check. I'll do that when more of ppapi/ is converted. BUG=345417 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252768

Patch Set 1 #

Patch Set 2 : Limit to shared_impl #

Patch Set 3 : remove DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1209 lines, -1442 lines) Patch
M ppapi/shared_impl/api_id.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/shared_impl/array_var.h View 1 chunk +2 lines, -6 lines 0 comments Download
M ppapi/shared_impl/array_var.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M ppapi/shared_impl/array_writer.h View 4 chunks +4 lines, -6 lines 0 comments Download
M ppapi/shared_impl/array_writer.cc View 5 chunks +21 lines, -25 lines 0 comments Download
M ppapi/shared_impl/callback_tracker.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M ppapi/shared_impl/dictionary_var.h View 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/shared_impl/dictionary_var.cc View 3 chunks +8 lines, -14 lines 0 comments Download
M ppapi/shared_impl/dir_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/file_growth.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/file_growth.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M ppapi/shared_impl/file_io_state_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/file_io_state_manager.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M ppapi/shared_impl/file_path.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ppapi/shared_impl/file_ref_create_info.h View 2 chunks +9 lines, -8 lines 0 comments Download
M ppapi/shared_impl/file_ref_create_info.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/shared_impl/file_type_conversion.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ppapi/shared_impl/flash_clipboard_format_registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/flash_clipboard_format_registry.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M ppapi/shared_impl/host_resource.h View 2 chunks +2 lines, -6 lines 0 comments Download
M ppapi/shared_impl/host_resource.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ppapi/shared_impl/id_assignment.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/shared_impl/id_assignment.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/media_stream_buffer.h View 1 chunk +1 line, -5 lines 0 comments Download
M ppapi/shared_impl/media_stream_buffer_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/media_stream_buffer_manager.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M ppapi/shared_impl/platform_file.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppapi_globals.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M ppapi/shared_impl/ppapi_nacl_plugin_args.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ppapi/shared_impl/ppapi_permissions.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/shared_impl/ppapi_permissions.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M ppapi/shared_impl/ppapi_preferences.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ppapi/shared_impl/ppb_audio_config_shared.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_audio_config_shared.cc View 4 chunks +13 lines, -16 lines 0 comments Download
M ppapi/shared_impl/ppb_audio_shared.cc View 5 chunks +16 lines, -23 lines 0 comments Download
M ppapi/shared_impl/ppb_crypto_shared.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/shared_impl/ppb_device_ref_shared.h View 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/shared_impl/ppb_device_ref_shared.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.h View 1 chunk +23 lines, -23 lines 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.h View 2 chunks +1 line, -4 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M ppapi/shared_impl/ppb_image_data_shared.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/shared_impl/ppb_input_event_shared.cc View 7 chunks +10 lines, -20 lines 0 comments Download
M ppapi/shared_impl/ppb_instance_shared.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M ppapi/shared_impl/ppb_memory_shared.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M ppapi/shared_impl/ppb_message_loop_shared.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M ppapi/shared_impl/ppb_opengles2_shared.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppb_opengles2_shared.cc View 36 chunks +592 lines, -466 lines 0 comments Download
M ppapi/shared_impl/ppb_tcp_socket_shared.h View 1 chunk +1 line, -8 lines 0 comments Download
M ppapi/shared_impl/ppb_tcp_socket_shared.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ppapi/shared_impl/ppb_trace_event_impl.h View 1 chunk +9 lines, -10 lines 0 comments Download
M ppapi/shared_impl/ppb_trace_event_impl.cc View 4 chunks +36 lines, -28 lines 0 comments Download
M ppapi/shared_impl/ppb_url_util_shared.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_var_shared.cc View 3 chunks +8 lines, -28 lines 0 comments Download
M ppapi/shared_impl/ppb_video_decoder_shared.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M ppapi/shared_impl/ppb_view_shared.h View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/shared_impl/ppb_view_shared.cc View 3 chunks +8 lines, -21 lines 0 comments Download
M ppapi/shared_impl/ppp_flash_browser_operations_shared.h View 1 chunk +2 lines, -5 lines 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M ppapi/shared_impl/proxy_lock.h View 9 chunks +20 lines, -22 lines 0 comments Download
M ppapi/shared_impl/proxy_lock.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ppapi/shared_impl/proxy_lock_unittest.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M ppapi/shared_impl/resource.h View 4 chunks +81 lines, -83 lines 0 comments Download
M ppapi/shared_impl/resource.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ppapi/shared_impl/resource_tracker.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ppapi/shared_impl/resource_tracker_unittest.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M ppapi/shared_impl/resource_var.cc View 1 chunk +5 lines, -15 lines 0 comments Download
M ppapi/shared_impl/scoped_pp_resource.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M ppapi/shared_impl/scoped_pp_var.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M ppapi/shared_impl/socket_option_data.h View 1 chunk +1 line, -5 lines 0 comments Download
M ppapi/shared_impl/socket_option_data.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M ppapi/shared_impl/test_globals.h View 3 chunks +9 lines, -10 lines 0 comments Download
M ppapi/shared_impl/test_globals.cc View 2 chunks +12 lines, -29 lines 0 comments Download
M ppapi/shared_impl/thread_aware_callback.h View 2 chunks +3 lines, -7 lines 0 comments Download
M ppapi/shared_impl/thread_aware_callback.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M ppapi/shared_impl/thread_aware_callback_unittest.cc View 4 chunks +14 lines, -33 lines 0 comments Download
M ppapi/shared_impl/time_conversion.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M ppapi/shared_impl/tracked_callback.h View 1 chunk +2 lines, -6 lines 0 comments Download
M ppapi/shared_impl/tracked_callback.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M ppapi/shared_impl/tracked_callback_unittest.cc View 6 chunks +9 lines, -14 lines 0 comments Download
M ppapi/shared_impl/unittest_utils.cc View 9 chunks +33 lines, -31 lines 0 comments Download
M ppapi/shared_impl/url_request_info_data.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M ppapi/shared_impl/url_response_info_data.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ppapi/shared_impl/var.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ppapi/shared_impl/var.cc View 5 chunks +20 lines, -55 lines 0 comments Download
M ppapi/shared_impl/var_tracker.h View 2 chunks +5 lines, -7 lines 0 comments Download
M ppapi/shared_impl/var_tracker.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M ppapi/shared_impl/var_tracker_unittest.cc View 2 chunks +7 lines, -20 lines 0 comments Download
M ppapi/shared_impl/var_value_conversions.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/var_value_conversions.cc View 10 chunks +11 lines, -24 lines 0 comments Download
M ppapi/shared_impl/var_value_conversions_unittest.cc View 4 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
teravest
lgtm
6 years, 10 months ago (2014-02-21 23:14:32 UTC) #1
teravest
lgtm
6 years, 10 months ago (2014-02-21 23:14:53 UTC) #2
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 10 months ago (2014-02-21 23:21:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/174213003/90001
6 years, 10 months ago (2014-02-21 23:22:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/174213003/90001
6 years, 10 months ago (2014-02-22 01:26:00 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:06:30 UTC) #6
Message was sent while issue was closed. 
Change committed as 252768

Powered by Google App Engine
This is Rietveld 408576698