Store arguments descriptor in ICData. Remove loading of arguments descriptor at unoptimized call si…

runtime/vm/intermediate_language_arm.cc

Index: runtime/vm/intermediate_language_arm.cc
===================================================================
--- runtime/vm/intermediate_language_arm.cc	(revision 24193)
+++ runtime/vm/intermediate_language_arm.cc	(working copy)
@@ -152,6 +152,7 @@
       Array::ZoneHandle(ArgumentsDescriptor::New(argument_count,
                                                  argument_names()));
   __ LoadObject(temp_reg, arguments_descriptor);
+  ASSERT(temp_reg == R4);
   compiler->GenerateDartCall(deopt_id(),
                              token_pos(),
                              &StubCode::CallClosureFunctionLabel(),
@@ -407,8 +408,12 @@
       equality_ic_data = original_ic_data.AsUnaryClassChecks();
     }
   } else {
+    const Array& arguments_descriptor =
+        Array::ZoneHandle(ArgumentsDescriptor::New(kNumberOfArguments,
+                                                   kNoArgumentNames));

[siva, 2013/06/19 23:07:15]

Why does this have to be a ZoneHandle?

[srdjan, 2013/06/20 00:12:34]

Handle.

     equality_ic_data = ICData::New(compiler->parsed_function().function(),
                                    Symbols::EqualOperator(),
+                                   arguments_descriptor,
                                    deopt_id,
                                    kNumArgumentsChecked);
   }
@@ -953,8 +958,12 @@
       relational_ic_data = ic_data()->AsUnaryClassChecks();
     }
   } else {
+    const Array& arguments_descriptor =
+        Array::ZoneHandle(ArgumentsDescriptor::New(kNumArguments,
+                                                   Array::ZoneHandle()));

[siva, 2013/06/19 23:07:15]

Ditto question regarding ZoneHandle
and use Object::null_array() instead of Array::ZoneHandle()

[srdjan, 2013/06/20 00:12:34]

Done.

     relational_ic_data = ICData::New(compiler->parsed_function().function(),
                                      function_name,
+                                     arguments_descriptor,
                                      deopt_id(),
                                      kNumArgsChecked);
   }