Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1687)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 17421003: Store arguments descriptor in ICData. Remove loading of arguments descriptor at unoptimized call si… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm.cc
===================================================================
--- runtime/vm/intermediate_language_arm.cc (revision 24207)
+++ runtime/vm/intermediate_language_arm.cc (working copy)
@@ -152,6 +152,7 @@
Array::ZoneHandle(ArgumentsDescriptor::New(argument_count,
argument_names()));
__ LoadObject(temp_reg, arguments_descriptor);
+ ASSERT(temp_reg == R4);
compiler->GenerateDartCall(deopt_id(),
token_pos(),
&StubCode::CallClosureFunctionLabel(),
@@ -407,8 +408,12 @@
equality_ic_data = original_ic_data.AsUnaryClassChecks();
}
} else {
+ const Array& arguments_descriptor =
+ Array::Handle(ArgumentsDescriptor::New(kNumberOfArguments,
+ kNoArgumentNames));
equality_ic_data = ICData::New(compiler->parsed_function().function(),
Symbols::EqualOperator(),
+ arguments_descriptor,
deopt_id,
kNumArgumentsChecked);
}
@@ -953,15 +958,19 @@
relational_ic_data = ic_data()->AsUnaryClassChecks();
}
} else {
+ const Array& arguments_descriptor =
+ Array::Handle(ArgumentsDescriptor::New(kNumArguments,
+ Object::null_array()));
relational_ic_data = ICData::New(compiler->parsed_function().function(),
function_name,
+ arguments_descriptor,
deopt_id(),
kNumArgsChecked);
}
compiler->GenerateInstanceCall(deopt_id(),
token_pos(),
kNumArguments,
- Array::ZoneHandle(), // No optional arguments.
+ Object::null_array(), // No optional args.
locs(),
relational_ic_data);
}
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698