Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 17421003: Store arguments descriptor in ICData. Remove loading of arguments descriptor at unoptimized call si… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 24207)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -546,9 +546,6 @@
const ICData& ic_data) {
ASSERT(!ic_data.IsNull());
ASSERT(FLAG_propagate_ic_data || (ic_data.NumberOfChecks() == 0));
- const Array& arguments_descriptor =
- Array::ZoneHandle(ArgumentsDescriptor::New(argument_count,
- argument_names));
uword label_address = 0;
if (is_optimizing() && (ic_data.NumberOfChecks() == 0)) {
if (ic_data.is_closure_call()) {
@@ -557,8 +554,7 @@
ExternalLabel target_label("InlineCache", label_address);
EmitInstanceCall(&target_label,
ICData::ZoneHandle(ic_data.AsUnaryClassChecks()),
- arguments_descriptor, argument_count,
- deopt_id, token_pos, locs);
+ argument_count, deopt_id, token_pos, locs);
return;
}
// Emit IC call that will count and thus may need reoptimization at
@@ -581,13 +577,13 @@
UNIMPLEMENTED();
}
ExternalLabel target_label("InlineCache", label_address);
- EmitOptimizedInstanceCall(&target_label, ic_data, arguments_descriptor,
+ EmitOptimizedInstanceCall(&target_label, ic_data,
argument_count, deopt_id, token_pos, locs);
return;
}
if (is_optimizing()) {
- EmitMegamorphicInstanceCall(ic_data, arguments_descriptor, argument_count,
+ EmitMegamorphicInstanceCall(ic_data, argument_count,
deopt_id, token_pos, locs);
return;
}
@@ -606,7 +602,7 @@
UNIMPLEMENTED();
}
ExternalLabel target_label("InlineCache", label_address);
- EmitInstanceCall(&target_label, ic_data, arguments_descriptor, argument_count,
+ EmitInstanceCall(&target_label, ic_data, argument_count,
deopt_id, token_pos, locs);
}
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698