Store arguments descriptor in ICData. Remove loading of arguments descriptor at unoptimized call si…

runtime/vm/flow_graph_builder.cc

Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc	(revision 24207)
+++ runtime/vm/flow_graph_builder.cc	(working copy)
@@ -979,7 +979,7 @@
                                                   name,
                                                   node->kind(),
                                                   arguments,
-                                                  Array::ZoneHandle(),
+                                                  Object::null_array(),
                                                   2,
                                                   owner()->ic_data_array());
   ReturnDefinition(call);
@@ -1223,7 +1223,7 @@
       PrivateCoreLibName(Symbols::_instanceOf()),
       node->kind(),
       arguments,
-      Array::ZoneHandle(),  // No argument names.
+      Object::null_array(),  // No argument names.
       kNumArgsChecked,
       owner()->ic_data_array());
   ReturnDefinition(call);
@@ -1293,7 +1293,7 @@
         PrivateCoreLibName(Symbols::_as()),
         node->kind(),
         arguments,
-        Array::ZoneHandle(),  // No argument names.
+        Object::null_array(),  // No argument names.
         kNumArgsChecked,
         owner()->ic_data_array());
     ReturnDefinition(call);
@@ -1407,7 +1407,7 @@
                                 Symbols::New(Token::Str(node->kind()))),
                             node->kind(),
                             arguments,
-                            Array::ZoneHandle(),
+                            Object::null_array(),
                             1,
                             owner()->ic_data_array());
   ReturnDefinition(call);
@@ -2526,7 +2526,7 @@
       node->token_pos(),
       name,
       Token::kGET,
-      arguments, Array::ZoneHandle(),
+      arguments, Object::null_array(),
       1,
       owner()->ic_data_array());
   ReturnDefinition(call);
@@ -2566,7 +2566,7 @@
                                                   name,
                                                   Token::kSET,
                                                   arguments,
-                                                  Array::ZoneHandle(),
+                                                  Object::null_array(),
                                                   2,  // Checked arg count.
                                                   owner()->ic_data_array());
   ReturnDefinition(call);
@@ -2583,7 +2583,7 @@
                            name,
                            Token::kSET,
                            arguments,
-                           Array::ZoneHandle(),
+                           Object::null_array(),
                            2,  // Checked argument count.
                            owner()->ic_data_array()));
   ReturnDefinition(BuildLoadExprTemp());
@@ -2652,7 +2652,7 @@
   ASSERT(!getter_function.IsNull());
   StaticCallInstr* call = new StaticCallInstr(node->token_pos(),
                                               getter_function,
-                                              Array::ZoneHandle(),  // No names.
+                                              Object::null_array(),  // No names
                                               arguments);
   ReturnDefinition(call);
 }
@@ -2719,7 +2719,7 @@
 
     call = new StaticCallInstr(node->token_pos(),
                                setter_function,
-                               Array::ZoneHandle(),  // No names.
+                               Object::null_array(),  // No names.
                                arguments);
   }
   if (result_is_needed) {
@@ -2940,7 +2940,7 @@
     // Generate static call to super operator.
     StaticCallInstr* load = new StaticCallInstr(node->token_pos(),
                                                 *super_function,
-                                                Array::ZoneHandle(),
+                                                Object::null_array(),
                                                 arguments);
     ReturnDefinition(load);
   } else {
@@ -2950,7 +2950,7 @@
                                                     Symbols::IndexToken(),
                                                     Token::kINDEX,
                                                     arguments,
-                                                    Array::ZoneHandle(),
+                                                    Object::null_array(),
                                                     checked_argument_count,
                                                     owner()->ic_data_array());
     ReturnDefinition(load);
@@ -3019,7 +3019,7 @@
     StaticCallInstr* store =
         new StaticCallInstr(node->token_pos(),
                             *super_function,
-                            Array::ZoneHandle(),
+                            Object::null_array(),
                             arguments);
     if (result_is_needed) {
       Do(store);
@@ -3037,7 +3037,7 @@
                               name,
                               Token::kASSIGN_INDEX,
                               arguments,
-                              Array::ZoneHandle(),
+                              Object::null_array(),
                               checked_argument_count,
                               owner()->ic_data_array());
     if (result_is_needed) {
@@ -3331,7 +3331,7 @@
   BuildPushArguments(*args, push_arguments);
   return new StaticCallInstr(args_pos,
                              no_such_method_func,
-                             Array::ZoneHandle(),
+                             Object::null_array(),
                              push_arguments);
 }
 StaticCallInstr* EffectGraphVisitor::BuildThrowNoSuchMethodError(
@@ -3382,12 +3382,12 @@
       Resolver::ResolveStatic(cls,
                               PrivateCoreLibName(Symbols::ThrowNew()),
                               arguments->length(),
-                              Array::ZoneHandle(),
+                              Object::null_array(),
                               Resolver::kIsQualified));
   ASSERT(!func.IsNull());
   return new StaticCallInstr(token_pos,
                              func,
-                             Array::ZoneHandle(),  // No names.
+                             Object::null_array(),  // No names.
                              arguments);
 }