Store arguments descriptor in ICData. Remove loading of arguments descriptor at unoptimized call si…

runtime/vm/code_patcher_arm_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/assembler.h"
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
@@ skipping 35 matching lines @@
 
 ASSEMBLER_TEST_GENERATE(IcDataAccess, assembler) {
   const String& class_name = String::Handle(Symbols::New("ownerClass"));
   const Script& script = Script::Handle();
   const Class& owner_class =
       Class::Handle(Class::New(class_name, script, Scanner::kDummyTokenIndex));
   const String& function_name =
       String::ZoneHandle(Symbols::New("callerFunction"));
   const Function& function = Function::ZoneHandle(
       Function::New(function_name, RawFunction::kRegularFunction,
                     true, false, false, false, owner_class, 0));

[siva, 2013/06/19 23:07:15]

I think function and function_name don't have to be zone handles here.

[srdjan, 2013/06/20 00:12:34]

Done.

 
   const String& target_name = String::Handle(String::New("targetFunction"));
-  const ICData& ic_data =
-      ICData::ZoneHandle(ICData::New(function, target_name, 15, 1));
   const Array& args_descriptor =
       Array::ZoneHandle(ArgumentsDescriptor::New(1, Array::Handle()));

[siva, 2013/06/19 23:07:15]

args_descriptor doesn't have to be a ZoneHandle anymore.

[srdjan, 2013/06/20 00:12:34]

Done.

+  const ICData& ic_data = ICData::ZoneHandle(ICData::New(function,
+                                                         target_name,
+                                                         args_descriptor,
+                                                         15,
+                                                         1));
 
-  __ LoadObject(R4, args_descriptor);
   __ LoadObject(R5, ic_data);
   ExternalLabel target_label(
       "InlineCache", StubCode::OneArgCheckInlineCacheEntryPoint());
   __ BranchLinkPatchable(&target_label);
   __ Ret();
 }
 
 
 ASSEMBLER_TEST_RUN(IcDataAccess, test) {
   uword return_address =
       test->entry() + test->code().Size() - Instr::kInstrSize;
   ICData& ic_data = ICData::Handle();
-  CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data, NULL);
+  CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);
   EXPECT_STREQ("targetFunction",
       String::Handle(ic_data.target_name()).ToCString());
   EXPECT_EQ(1, ic_data.num_args_tested());
   EXPECT_EQ(0, ic_data.NumberOfChecks());
 }
 
 }  // namespace dart
 
 #endif  // TARGET_ARCH_ARM