Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: runtime/vm/instructions_mips.cc

Issue 17421003: Store arguments descriptor in ICData. Remove loading of arguments descriptor at unoptimized call si… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/instructions_mips.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/constants_mips.h" 8 #include "vm/constants_mips.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/instructions.h" 10 #include "vm/instructions.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 RawICData* CallPattern::IcData() { 122 RawICData* CallPattern::IcData() {
123 if (ic_data_.IsNull()) { 123 if (ic_data_.IsNull()) {
124 Register reg; 124 Register reg;
125 args_desc_load_end_ = DecodeLoadObject(ic_data_load_end_, &reg, &ic_data_); 125 args_desc_load_end_ = DecodeLoadObject(ic_data_load_end_, &reg, &ic_data_);
126 ASSERT(reg == S5); 126 ASSERT(reg == S5);
127 } 127 }
128 return ic_data_.raw(); 128 return ic_data_.raw();
129 } 129 }
130 130
131 131
132 RawArray* CallPattern::ArgumentsDescriptor() { 132 RawArray* CallPattern::ClosureArgumentsDescriptor() {
133 if (args_desc_.IsNull()) { 133 if (args_desc_.IsNull()) {
134 IcData(); // Loading of the ic_data must be decoded first, if not already. 134 IcData(); // Loading of the ic_data must be decoded first, if not already.
135 Register reg; 135 Register reg;
136 DecodeLoadObject(args_desc_load_end_, &reg, &args_desc_); 136 DecodeLoadObject(args_desc_load_end_, &reg, &args_desc_);
137 ASSERT(reg == S4); 137 ASSERT(reg == S4);
138 } 138 }
139 return args_desc_.raw(); 139 return args_desc_.raw();
140 } 140 }
141 141
142 142
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 const uint16_t target_hi = target_address >> 16; 211 const uint16_t target_hi = target_address >> 16;
212 212
213 lui->SetInstructionBits((lui_bits & 0xffff0000) | target_hi); 213 lui->SetInstructionBits((lui_bits & 0xffff0000) | target_hi);
214 ori->SetInstructionBits((ori_bits & 0xffff0000) | target_lo); 214 ori->SetInstructionBits((ori_bits & 0xffff0000) | target_lo);
215 } 215 }
216 216
217 } // namespace dart 217 } // namespace dart
218 218
219 #endif // defined TARGET_ARCH_MIPS 219 #endif // defined TARGET_ARCH_MIPS
220 220
OLDNEW
« no previous file with comments | « runtime/vm/instructions_mips.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698