Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Side by Side Diff: runtime/vm/instructions_arm.cc

Issue 17421003: Store arguments descriptor in ICData. Remove loading of arguments descriptor at unoptimized call si… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/instructions_arm.h ('k') | runtime/vm/instructions_mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/constants_arm.h" 8 #include "vm/constants_arm.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/instructions.h" 10 #include "vm/instructions.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 RawICData* CallPattern::IcData() { 112 RawICData* CallPattern::IcData() {
113 if (ic_data_.IsNull()) { 113 if (ic_data_.IsNull()) {
114 Register reg; 114 Register reg;
115 args_desc_load_end_ = DecodeLoadObject(ic_data_load_end_, &reg, &ic_data_); 115 args_desc_load_end_ = DecodeLoadObject(ic_data_load_end_, &reg, &ic_data_);
116 ASSERT(reg == R5); 116 ASSERT(reg == R5);
117 } 117 }
118 return ic_data_.raw(); 118 return ic_data_.raw();
119 } 119 }
120 120
121 121
122 RawArray* CallPattern::ArgumentsDescriptor() { 122 RawArray* CallPattern::ClosureArgumentsDescriptor() {
123 if (args_desc_.IsNull()) { 123 if (args_desc_.IsNull()) {
124 IcData(); // Loading of the ic_data must be decoded first, if not already. 124 IcData(); // Loading of the ic_data must be decoded first, if not already.
125 Register reg; 125 Register reg;
126 DecodeLoadObject(args_desc_load_end_, &reg, &args_desc_); 126 DecodeLoadObject(args_desc_load_end_, &reg, &args_desc_);
127 ASSERT(reg == R4); 127 ASSERT(reg == R4);
128 } 128 }
129 return args_desc_.raw(); 129 return args_desc_.raw();
130 } 130 }
131 131
132 132
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 uword movt_ip = 0xe340c000 | ((target_hi >> 12) << 16) | (target_hi & 0xfff); 192 uword movt_ip = 0xe340c000 | ((target_hi >> 12) << 16) | (target_hi & 0xfff);
193 *reinterpret_cast<uword*>(pc_ + (0 * Instr::kInstrSize)) = movw_ip; 193 *reinterpret_cast<uword*>(pc_ + (0 * Instr::kInstrSize)) = movw_ip;
194 *reinterpret_cast<uword*>(pc_ + (1 * Instr::kInstrSize)) = movt_ip; 194 *reinterpret_cast<uword*>(pc_ + (1 * Instr::kInstrSize)) = movt_ip;
195 CPU::FlushICache(pc_, 2 * Instr::kInstrSize); 195 CPU::FlushICache(pc_, 2 * Instr::kInstrSize);
196 } 196 }
197 197
198 } // namespace dart 198 } // namespace dart
199 199
200 #endif // defined TARGET_ARCH_ARM 200 #endif // defined TARGET_ARCH_ARM
201 201
OLDNEW
« no previous file with comments | « runtime/vm/instructions_arm.h ('k') | runtime/vm/instructions_mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698