Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1742073002: [wasm] Properly plumb the origin of the WASM module from asm.js translation. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
bradnelson, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Properly plumb the origin of the WASM module from asm.js translation. R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Committed: https://crrev.com/8344687c76134f5b1d1a148e8749251576025bab Cr-Commit-Position: refs/heads/master@{#34345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -30 lines) Patch
M src/compiler/wasm-compiler.cc View 6 chunks +20 lines, -4 lines 0 comments Download
M src/wasm/module-decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/module-decoder.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M src/wasm/wasm-js.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M src/wasm/wasm-module.h View 4 chunks +6 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +15 lines, -0 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 9 months ago (2016-02-27 17:24:10 UTC) #1
bradnelson
lgtm lgtm, thanks, scratch some more off my list :-)
4 years, 9 months ago (2016-02-27 20:36:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742073002/1
4 years, 9 months ago (2016-02-27 20:36:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-27 20:39:02 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-02-27 20:40:18 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8344687c76134f5b1d1a148e8749251576025bab
Cr-Commit-Position: refs/heads/master@{#34345}

Powered by Google App Engine
This is Rietveld 408576698